Improve doctest #24980
Open
Improve doctest #24980
+58
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace anytype with *Io.Writer when writing to a file, making the code more readable. - Update the escapeHtml function to use Io.Writer.Allocating.fromArrayList. - Remove the writeEscapedLines function, since line numbers where removed. - Remove the escape parameter from the printShell function, since in doctest.zig it is always false. - Update the termColor function to also handle HTML escape characters. This allow removing a call to escapeHtml when processing stdout and stderr, simplifying the code. - Update the link for checking the colors used by the compiler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to split the changes into two commits.
The first commit removes dead and deprecated code, but without updating all use of deprecated the std.array_list.Managed(u8).
The second commit tries to make the code more consistent. You can see an example of the old code by searching the
printfunction.Unfortunately, there were more changes I had expected:
1 file changed, 25 insertions(+), 24 deletions(-)If you don't like it, you can simply ignore the second commit.