std.fs.path: fix resolveWindows panic with relative drive paths #25709
      
        
          +17
        
        
          −4
        
        
          
        
      
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Summary
Fixes a panic in
std.fs.path.resolveWindowswhen processing relative drive paths.Issue
When calling
resolveWindows(&[_][]const u8{ "c:foo", "bar" }), the function would panic with "index out of bounds: index 0, len 0".Root Causes
compareDiskDesignatorstried to accessdisk_designator[0]without checking if the string was emptyfoo\barinstead ofC:foo\bar)\after drive letter for relative paths (would produceC:\fooinstead ofC:foo)Testing
zig build test-std -Dtest-filter="resolveWindows"