feat:object storage aksk uses k8s secret storage #257
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: doubledna The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @doubledna! It looks like this is your first PR to zilliztech/milvus-helm 🎉 |
doubledna
requested review from
LoveEachDay
and removed request for
LoveEachDay and
haorenfsa
doubledna
force-pushed
the
gaolincheng/s3_aksk_use_secret
branch
2 times, most recently
from
7e1edaf to
508887d
Compare
charts/milvus/values.yaml
Outdated
| port: "" | ||
| accessKey: "" | ||
| secretKey: "" | ||
| existingSecret: false |
There was a problem hiding this comment.
combine the values like this:
existingSecret:
enabled: false
name: s3-credentials
accessKey: "accessKey"
secretKey: "secretKey"
508887d to
08bc22e
Compare
charts/milvus/README.md
Outdated
| $ helm upgrade --install my-release --set cluster.enabled=false --set standalone.messageQueue=kafka --set etcd.replicaCount=1 --set pulsarv3.enabled=false --set kafka.enabled=true --set minio.mode=standalone zilliztech/milvus | ||
| ``` | ||
| If you need to use standalone mode with embedded ETCD and local storage (without starting MinIO and additional ETCD), you can use the following steps: | ||
| use external S3 as object storage and store aksk in secret |
There was a problem hiding this comment.
Should put this into a separate section not under Deploy Milvus with standalone mode.
charts/milvus/README.md
Outdated
| ``` | ||
| If you need to use standalone mode with embedded ETCD and local storage (without starting MinIO and additional ETCD), you can use the following steps: | ||
| use external S3 as object storage and store aksk in secret | ||
| 1. Create a secret with name `s3-credentials` in namespace `default` or use existing s3 aksk secret |
There was a problem hiding this comment.
No need to limit the namespace to default namespace.
doubledna
force-pushed
the
gaolincheng/s3_aksk_use_secret
branch
from
08bc22e to
2b49aa5
Compare
doubledna
force-pushed
the
gaolincheng/s3_aksk_use_secret
branch
from
2b49aa5 to
86923f0
Compare
Signed-off-by: doubledna <gaolin.cheng@zilliz.com>
doubledna
force-pushed
the
gaolincheng/s3_aksk_use_secret
branch
from
86923f0 to
dd725ca
Compare
|
bump! it's really needed |
4 participants
What this PR does / why we need it: milvus connect external s3 aksk uses k8s secret storage. / s3 aksk stored in helm value is prone to leakage.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[mychartname])