[milvus] Add terminationGracePeriodSeconds to milvus components #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: thbelmont The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Collaborator
|
Welcome @thbelmont! It looks like this is your first PR to zilliztech/milvus-helm 🎉 |
thbelmont
force-pushed
the
add-termination-grace-period
branch
from
7e19a9c to
fba154c
Compare
thbelmont
force-pushed
the
add-termination-grace-period
branch
from
fba154c to
4dab67b
Compare
Signed-off-by: Loic Bethmont <lbethmont@antidot.net>
thbelmont
force-pushed
the
add-termination-grace-period
branch
from
4dab67b to
b7c93b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When upgrading/restarting a milvus cluster deployed with this helm chart, the default 30s value for terminationGracePeriodSeconds can be too short to allow the data loaded in terminating querynodes to be migrated to running nodes, leading to failed searches.
This PR lets users tune this value to ensure upgrades without interruption of the search service.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[mychartname])