Skip to content

Conversation

@XuGuangnian
Copy link

@XuGuangnian XuGuangnian commented Jan 8, 2026

What this PR does / why we need it:

This PR fixes two image repository configuration issues:

  1. Adds missing repository field for minio image: The minio image configuration was missing the repository field, which forces users to manually add repository: minio/minio when using private image registries. This change ensures consistency with other image configurations in the chart. (fix Minio image repository configuration missing #274 )

  2. Removes quotes from etcd repository value: The etcd repository value was wrapped in double quotes ("milvusdb/etcd"), which was the only repository value in the entire codebase using quotes. Removing the quotes makes it easier for scripts to customize the repository for private registry usage and maintains consistency across all repository configurations.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Title of the PR starts with chart name (e.g. [mychartname])
  • PR only contains changes for one chart

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: XuGuangnian
To complete the pull request process, please assign haorenfsa after the PR has been reviewed.
You can assign the PR to them by writing /assign @haorenfsa in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
Copy link
Collaborator

Welcome @XuGuangnian! It looks like this is your first PR to zilliztech/milvus-helm 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minio image repository configuration missing

2 participants