Skip to content

Comments

Added EL10, bug fixes#25

Open
HonestLocksmith wants to merge 7 commits intozinongli:mainfrom
HonestLocksmith:Updates
Open

Added EL10, bug fixes#25
HonestLocksmith wants to merge 7 commits intozinongli:mainfrom
HonestLocksmith:Updates

Conversation

@HonestLocksmith
Copy link
Contributor

No description provided.

@zinongli
Copy link
Owner

zinongli commented Feb 4, 2025

Hi! There are some problems with the double sided car keys.

截屏2025-02-03 21 44 09 截屏2025-02-03 21 44 34

Do you know where the angular lines on the right side of the screen come from?

And, to answer your previous question about where I got the .clearance values. I get those by testing each format myself. The clearance value is the maximum sum of two neighboring pin's depth value such that their diagonal cut lines won't intersect each other.

Let's look at some examples

  1. Clearance too large:
截屏2025-02-03 21 40 58

You can see here pin 1 and pin 2 sums to 6 (3 and 3 in respect to 0). Their diagonal cuts intersect and shouldn't be drawn as it's physically impossible to appear on a real key. So what value of clearance should we use?

截屏2025-02-03 21 41 11

By looking at this combination, 2 and 2 equal 4. This is where the two diagonal lines just starts to intersect each other. So our clearance should be 4.

截屏2025-02-03 21 53 59

See here after adjusting the clearance to be 4, the two lines won't keep going after they intersect.

  1. Clearance too small
截屏2025-02-03 21 40 44

Here, the lines aren't intersecting each other yet. But because clerance is too small, the app "thinks" the two lines should be connected at this sum of neighboring depths. So it drags the two diagonal lines to be together. And it results in unwanted angles.

For every format I always manually check the clearance before commiting them to the repo. If you can do that before making the PR it would be nice. But if you don't wanna bother that's fine. I check them before merging PRs anyway.

@zinongli zinongli marked this pull request as draft February 4, 2025 03:05
@HonestLocksmith HonestLocksmith marked this pull request as ready for review February 23, 2025 04:06
@HonestLocksmith
Copy link
Contributor Author

The extra line is an artifact from the elbow inch length that must match the first pin inch for tip stopped keys. I'll have to see what i can do about it. Thanks for clarifying the clearance issue as well.

@Tuyeee
Copy link

Tuyeee commented Apr 22, 2025

Hello
When will this version with EL10 finally be available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants