Fix JSON codecs to initialize empty collection properly + bump up coverage limits + remove coverage exclusion for compile-time code#1210
Merged
plokhotnyuk merged 1 commit intozio:mainfrom Mar 12, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates JSON binary codec derivation internals (especially record-field handling for default/missing collections) and revises per-module scoverage minimum thresholds in the build.
Changes:
- Refactors record
FieldInfoto use anemptyCollectionConstructor(instead of a cached empty instance) and streamlines optional/collection flags. - Re-tunes
coverageMinimumStmtTotal/coverageMinimumBranchTotalfor multiple subprojects inbuild.sbt(and removes some prior per-module coverage exclusions).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| schema/shared/src/main/scala/zio/blocks/schema/json/JsonBinaryCodecDeriver.scala | Refactors how missing collection fields are defaulted and adjusts field metadata / encoding paths. |
| build.sbt | Updates per-project scoverage minimums and removes prior macro-source coverage exclusions; also changes benchmark project coverage settings. |
You can also share your feedback on Copilot code review. Take the survey.
schema/shared/src/main/scala/zio/blocks/schema/json/JsonBinaryCodecDeriver.scala
Outdated
Show resolved
Hide resolved
…erage limits + remove coverage exclusion for compile-time code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.