fix(openapi): add discriminator property to case schemas in oneOf #3872
+56
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
developerfred
commented
Dec 23, 2025
developerfred
commented
- Fixes OpenAPI generator ignores @discriminatorName and @caseName annotations for sealed traits #3868: OpenAPI generator now includes discriminator property in each case schema
- When using @discriminatorName and @casename annotations on sealed traits, the generated OpenAPI spec now properly includes the discriminator property in each individual case schema, not just at the union level
- This ensures proper oneOf with discriminator structure as expected by OpenAPI spec
- Fixes zio#3868: OpenAPI generator now includes discriminator property in each case schema - When using @discriminatorName and @casename annotations on sealed traits, the generated OpenAPI spec now properly includes the discriminator property in each individual case schema, not just at the union level - This ensures proper oneOf with discriminator structure as expected by OpenAPI spec
developerfred
requested review from
987Nabil,
jdegoes,
kyri-petrou and
vigoo
as code owners
✅ Deploy Preview for zio-http ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
- Fix JsonSchema.scala compilation error (caseName variable shadowing) - Add try-catch for git commands in build.sbt to handle missing tags - Add @nowarn annotations to suppress unused parameter warnings - Ensure code compiles without errors or warnings
developerfred
force-pushed
the
codingsh/fix-openapi-discriminator
branch
from
e6ee20d to
a555c91
Compare
Contributor
|
👋 This PR is being automatically closed because it has had a failed CI build for over 3 days. If you're still working on this, please:
Thank you for your contribution! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.