fix nocontent unit decoding #3873
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes zio#3868: OpenAPI generator now includes discriminator property in each case schema - When using @discriminatorName and @casename annotations on sealed traits, the generated OpenAPI spec now properly includes the discriminator property in each individual case schema, not just at the union level - This ensures proper oneOf with discriminator structure as expected by OpenAPI spec
Problem: - Endpoints with NoContent status failed on client side with "Malformed request body failed to decode: Non-empty body cannot be decoded as Unit" - Server correctly omits content-length header for NoContent responses (following HTTP spec) - Client depended on content-length header existence to decode Unit values - This created a mismatch where client tried to decode non-empty body as Unit Solution: - Modified BodyCodec.decodeFromBody signatures to accept Status parameter - Updated unit decoding logic to treat body as empty for NoContent status - Updated EncoderDecoder to pass Status to decodeFromBody calls - Added necessary Status import to BodyCodec Changes: - BodyCodec.scala: Updated decodeFromBody method signatures and unit decoding logic - EncoderDecoder.scala: Updated decodeBody method signature and calls to pass Status - Added Status import to BodyCodec.scala This ensures NoContent responses are properly handled on client side while maintaining backward compatibility.
developerfred
requested review from
987Nabil,
jdegoes,
kyri-petrou and
vigoo
as code owners
❌ Deploy Preview for zio-http failed. Why did it fail? →
|
Contributor
|
👋 This PR is being automatically closed because it has had a failed CI build for over 3 days. If you're still working on this, please:
Thank you for your contribution! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3861