Skip to content

Conversation

@Pr0methean
Copy link
Member

🤖 New release

  • zip: 6.0.0 -> 7.0.0 (⚠ API breaking changes)

zip breaking changes

--- failure feature_missing: package feature removed or renamed ---

Description:
A feature has been removed from this package's Cargo.toml. This will break downstream crates which enable that feature.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#cargo-feature-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/feature_missing.ron

Failed in:
  feature zeroize in the package's Cargo.toml
  feature xz-static in the package's Cargo.toml
  feature pbkdf2 in the package's Cargo.toml
  feature sha1 in the package's Cargo.toml
  feature hmac in the package's Cargo.toml
  feature getrandom in the package's Cargo.toml
  feature lzma-static in the package's Cargo.toml
Changelog

7.0.0 - 2025-12-04

🚀 Features

  • (SimpleFileOptions) const DEFAULT implementation (#474)
  • ZipWriter set_auto_large_file() method to enable large-file data descriptor when necessary (#468)

🐛 Bug Fixes

⚙️ Miscellaneous Tasks

  • Revert version bump so that release-plz will trigger
  • expose more flate2 feature flags (#476)
  • Next release will be 7.0.0
  • release v6.0.0 (#442)

Deps

  • Bump lzma-rust2 to v0.15 (#465)

⚙️ Miscellaneous Tasks


This PR was generated with release-plz.

@amazon-q-developer
Copy link
Contributor

Code review in progress. Analyzing for code quality issues and best practices. You can monitor the review status in the checks section at the bottom of this pull request. Detailed findings will be posted upon completion.

Using Amazon Q Developer for GitHub

Amazon Q Developer1 is an AI-powered assistant that integrates directly into your GitHub workflow, enhancing your development process with intelligent features for code development, review, and transformation.

Slash Commands

Command Description
/q <message> Chat with the agent to ask questions or request revisions
/q review Requests an Amazon Q powered code review
/q help Displays usage information

Features

Agentic Chat
Enables interactive conversation with Amazon Q to ask questions about the pull request or request specific revisions. Use /q <message> in comment threads or the review body to engage with the agent directly.

Code Review
Analyzes pull requests for code quality, potential issues, and security concerns. Provides feedback and suggested fixes. Automatically triggered on new or reopened PRs (can be disabled for AWS registered installations), or manually with /q review slash command in a comment.

Customization

You can create project-specific rules for Amazon Q Developer to follow:

  1. Create a .amazonq/rules folder in your project root.
  2. Add Markdown files in this folder to define rules (e.g., cdk-rules.md).
  3. Write detailed prompts in these files, such as coding standards or best practices.
  4. Amazon Q Developer will automatically use these rules when generating code or providing assistance.

Example rule:

All Amazon S3 buckets must have encryption enabled, enforce SSL, and block public access.
All Amazon DynamoDB Streams tables must have encryption enabled.
All Amazon SNS topics must have encryption enabled and enforce SSL.
All Amazon SNS queues must enforce SSL.

Feedback

To provide feedback on Amazon Q Developer, create an issue in the Amazon Q Developer public repository.

For more detailed information, visit the Amazon Q for GitHub documentation.

Footnotes

  1. Amazon Q Developer uses generative AI. You may need to verify generated code before using it in your environment. See the AWS Responsible AI Policy.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Pr0methean, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request orchestrates the release of zip crate version 7.0.0, incorporating several new features, critical bug fixes, and dependency updates. The most notable aspect is the introduction of breaking changes through the removal of deprecated feature flags, which streamlines the crate's feature set. The update also enhances ZIP64 support and improves documentation, aiming to provide a more robust and maintainable library.

Highlights

  • Major Version Release: The zip crate has been updated to version 7.0.0, signifying a new major release with significant changes.
  • Breaking API Changes: Several feature flags, including zeroize, xz-static, pbkdf2, sha1, hmac, getrandom, and lzma-static, have been removed. This constitutes a breaking change that may affect downstream crates relying on these features.
  • New Features: Introduced a const DEFAULT implementation for SimpleFileOptions and a set_auto_large_file() method for ZipWriter to automatically enable large-file data descriptors when necessary.
  • Bug Fixes and Dependencies: Addressed cargo documentation warnings, ensured correct writing of ZIP64 data descriptors, and temporarily pinned the generic-array dependency to work around a known issue. The lzma-rust2 dependency was also bumped to v0.15.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@amazon-q-developer amazon-q-developer bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a standard release PR for v7.0.0 that properly follows Conventional Commits format and includes comprehensive changelog updates. The version bump from 6.0.0 to 7.0.0 is appropriate given the breaking changes mentioned in the PR description (removal of deprecated feature flags).

The changelog entry is well-structured and includes all necessary sections (Features, Bug Fixes, Miscellaneous Tasks, Dependencies). One minor issue was identified regarding an external link that should be replaced with a reference to maintain consistency with approved domain policies.

Overall, the release preparation looks good and ready for merge once the external link issue is addressed.


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request prepares for the v7.0.0 release by updating the version in Cargo.toml and adding the corresponding entry to CHANGELOG.md. The changes look correct for a major release, especially given the breaking changes. I've provided one suggestion to improve the structure and clarity of the new changelog entry to make it more user-friendly.

Pr0methean and others added 2 commits December 4, 2025 11:55
Co-authored-by: amazon-q-developer[bot] <208079219+amazon-q-developer[bot]@users.noreply.github.com>
Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
@Pr0methean Pr0methean enabled auto-merge December 4, 2025 20:00
@Pr0methean Pr0methean added this pull request to the merge queue Dec 5, 2025
@Pr0methean Pr0methean closed this Dec 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a manual request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants