feat: domain access control and runtime specific code#67
Merged
Conversation
rushby
requested review from
95DDB,
davehorizen,
jmontesdeocanuez,
la10736 and
yurikoinaba
yurikoinaba
reviewed
Nov 13, 2025
la10736
requested changes
Nov 14, 2025
la10736
left a comment
la10736
left a comment
There was a problem hiding this comment.
Great job.
Just some little things. The most important one is the one related to the removeSubmitter behavior should emit a domain change event iff the domain is in the hold state and you're removing all address in the allow-list.
la10736
requested changes
Nov 14, 2025
la10736
left a comment
la10736
left a comment
There was a problem hiding this comment.
Please can you fix the test about removing submitter emit a domain changed event?
Moreover, can you let me know why you didn't use api.consts.system.version to get the version info?
Please don't resolve the comments otherwise it's hard to me check what is met and what is not
la10736
approved these changes
Nov 17, 2025
la10736
left a comment
la10736
left a comment
There was a problem hiding this comment.
LGTM!
Just a little opinionated comment... feel free to do whatever you want.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.