Web3 1940 ezkl and plain/zk ultrahonk variants#68
Merged
Conversation
rushby
requested review from
95DDB,
DimitrisPapac,
davehorizen,
jmontesdeocanuez,
la10736 and
yurikoinaba
yurikoinaba
approved these changes
Nov 17, 2025
Collaborator
yurikoinaba
left a comment
yurikoinaba
left a comment
There was a problem hiding this comment.
Just a comment on the new version - it should highlight a breaking change
la10736
reviewed
Nov 17, 2025
There was a problem hiding this comment.
The code is Ok for me, but I didn't find any logic that take care the runtime version to handle the right ultrahonk version (with or without Zk variant).
Also for ezkl should be gated by runtime version. In this case it's a smaller issue because in the worst case the user receive an error from the chain that the verifier is not present, but in general should be possible to have a different set of verifies on different runtimes.
I think that is a good occasion to implement it and use the same pattern in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.