Skip to content

docs: extended relayer docs#149

Merged
zkfriendly merged 6 commits intomainfrom
docs/relayer-setup
Jan 26, 2026
Merged

docs: extended relayer docs#149
zkfriendly merged 6 commits intomainfrom
docs/relayer-setup

Conversation

@benceharomi
Copy link
Copy Markdown
Member

@benceharomi benceharomi commented Jan 22, 2026

Summary by CodeRabbit

  • Documentation

    • Restructured Relayer setup into clear prerequisites and a step‑by‑step configuration and deployment flow, including instructions to prepare configuration and environment files, build contracts, apply migrations, and start services.
  • Chores

    • Simplified Docker Compose by removing the top‑level version declaration; service definitions and behavior remain unchanged.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 22, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Removed the top-level version: '3.8' from docker-compose.yaml. Rewrote packages/relayer/README.md into prerequisites and a numbered setup: build contracts, create/populate config.json, place .ic.pem, configure .env, start services with docker compose up --build -d, then run sqlx migrate run.

Changes

Cohort / File(s) Summary
Compose file
docker-compose.yaml
Removed the top-level version: '3.8' line; service, volume and other definitions unchanged.
Relayer documentation
packages/relayer/README.md
Major rewrite: replaced "Build" with "Prerequisites" (docker compose, sqlx-cli), added numbered steps to build contracts via yarn workspace, copy config.exampleconfig.json and populate chains.<network>.privateKey, prover.url/apiKey, icp.wallet_canisterId, place .ic.pem in packages/relayer/, copy/edit .env from .env.example, start services (docker compose up --build -d), and run migrations (sqlx migrate run --source ./packages/relayer/migrations).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • zkfriendly

Poem

🐇 I nibbled notes and smoothed each line,
Tweaked the steps so setups now align.
Contracts built, configs snug in place,
Docker wakes — migrations join the chase.
A floppy-eared cheer for tidy pace!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided by the author, missing all required template sections including summary, type of change, testing details, and checklist items. Add a complete pull request description following the template, including a summary of changes, type of change classification, testing verification, and completion checklist.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'docs: extended relayer docs' is directly related to the changeset, which extends the relayer documentation with new setup procedures and prerequisites.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@packages/relayer/README.md`:
- Line 35: Update the README text that currently reads "In the the repository
root, copy and edit the `.env` file:" by removing the duplicate word "the" so it
reads "In the repository root, copy and edit the `.env` file:"; edit the line
containing that exact phrase in the README.md to correct the typo.
🧹 Nitpick comments (3)
packages/relayer/README.md (3)

31-31: Clarify the location of the .ic.pem file.

The term "relayer root" is ambiguous. Line 20 refers to "relayer package directory (./packages/relayer)" — please clarify whether "relayer root" means the same location or if it refers to the repository root.

📝 Suggested clarification
-> Note: do not forget to place the `.ic.pem` file in the relayer root
+> Note: do not forget to place the `.ic.pem` file in the relayer package directory (`./packages/relayer`)

43-47: Specify the working directory for the cargo build command.

Unlike Steps 2, 3, and 5, this step doesn't specify where to run cargo build --release. Users may be unclear whether to run it from the repository root or the relayer package directory (./packages/relayer).

📝 Suggested clarification
 ### 4. Build relayer
+
+From the relayer package directory (`./packages/relayer`):
 
 ```bash
 cargo build --release

59-63: Specify the working directory and clarify the database configuration.

This step has two clarity issues:

  1. The working directory is not specified. Based on the pattern in other steps, please clarify whether this should be run from the repository root.
  2. The hardcoded DATABASE_URL contains credentials (relayer:relayer_password) that may need to align with the .env file configured in Step 3. Please clarify whether these should match or if they serve different purposes.
📝 Suggested clarification
 ### 6. Apply the migrations
+
+From the repository root:
 
 ```bash
 DATABASE_URL=postgres://relayer:relayer_password@localhost:5432/relayer sqlx migrate run

Additionally, consider adding a note if the DATABASE_URL credentials should match the .env configuration, or explain why they differ.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@packages/relayer/README.md`:
- Around line 28-29: The README references a non-existent prover setup guide
link in the bullet for `prover.*`; fix by either updating the link target in the
`prover.*` bullet to the correct existing documentation location (replace the
broken `../prover/` URL with the actual relative path or URL to the prover
guide) or add a new README.md in the prover package so `../prover/` resolves;
ensure the `prover.*` bullet text remains accurate after the change.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@packages/relayer/README.md`:
- Around line 59-63: The README's migration step is ambiguous: instruct the
reader to run sqlx migrate from the relayer package or pass the migrations
source explicitly; update the step that shows the sqlx migrate run command
(reference the sqlx migrate run command and the migrations directory at
packages/relayer/migrations) to either (a) tell users to cd into
packages/relayer before running DATABASE_URL=... sqlx migrate run or (b) use
DATABASE_URL=... sqlx migrate run --source ./packages/relayer/migrations so sqlx
can find the migrations without changing directories.

@zkfriendly zkfriendly merged commit 7c74421 into main Jan 26, 2026
5 of 6 checks passed
@zkfriendly zkfriendly deleted the docs/relayer-setup branch January 26, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants