Skip to content

chore: remove unneeded prover package#150

Merged
zkfriendly merged 1 commit intomainfrom
chore/remove-unneeded-prover
Jan 26, 2026
Merged

chore: remove unneeded prover package#150
zkfriendly merged 1 commit intomainfrom
chore/remove-unneeded-prover

Conversation

@benceharomi
Copy link
Copy Markdown
Member

@benceharomi benceharomi commented Jan 23, 2026

Summary by CodeRabbit

  • Chores
    • Removed prover service infrastructure, including Docker build configuration, setup scripts, and supporting Python modules.
    • Updated documentation to remove references to the prover service.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 23, 2026

📝 Walkthrough

Walkthrough

The entire prover package and its supporting infrastructure have been removed from the repository. This includes configuration ignore patterns, documentation references, Docker build setup, shell scripts, Python modules providing Flask and Modal-based APIs, and runtime dependencies. All prover-related files are deleted while other codebase sections remain unchanged.

Changes

Cohort / File(s) Summary
Configuration and Ignore Patterns
.dockerignore, .gitignore
Removed prover-related ignore patterns (4 lines in .gitignore, 3 lines in .dockerignore); prover paths no longer excluded from version control or Docker context.
Documentation
README.md, docs/getting-started.md
Removed prover package documentation block from README; updated Relayer API section to remove reference to prover.
Prover Package - Infrastructure
packages/prover/Dockerfile, packages/prover/local_setup.sh
Removed Docker build configuration (87 lines) and local environment setup script (36 lines) that handled CUDA-based image, dependencies, artifact downloads, and build orchestration.
Prover Package - Scripts
packages/prover/circom_proofgen.sh
Removed witness generation and proof generation shell script (56 lines) that executed C\++ witness generator and conditional Groth16 or RAPIDSNARK prover logic.
Prover Package - Python Modules
packages/prover/core.py, packages/prover/local.py, packages/prover/modal_server.py
Removed core proof generation functions (gen_email_auth_proof, store_input, load_proof, etc.); removed Flask-based local HTTP API (36 lines); removed Modal-deployed WSGI application with Google Cloud logging (66 lines).
Prover Package - Dependencies
packages/prover/requirements.txt
Removed Python dependencies: flask, waitress, gdown, jsonify, requests, modal, google, google-cloud-logging (8 lines).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Poem

🐰 The prover's gone, a clean sweep today,
No more CUDA, no Flask on display,
Modal servers and circuits bid adieu,
The repository's lighter, refreshed and anew! 🚀

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided, making it impossible to verify compliance with the repository's description template requiring summary, issue reference, type of change, testing details, and checklist items. Add a detailed description following the template: include a summary of why the prover package was removed, reference any related issue, specify the change type, document testing performed, and complete the provided checklist.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: removal of the prover package, which aligns with the substantial deletions across multiple prover-related files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zkfriendly zkfriendly merged commit 9eaf4b0 into main Jan 26, 2026
6 checks passed
@zkfriendly zkfriendly deleted the chore/remove-unneeded-prover branch January 26, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants