ci: update to improved check-coverage action#5
Merged
benceharomi merged 2 commits intomainfrom Jul 1, 2025
Merged
Conversation
📊 Coverage Report
Details: 292 of 303 lines covered. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the existing coverage check by updating the CI workflow and improving the check-coverage composite action.
- Restricts CI
pushevents to themainbranch and passesGITHUB_TOKENto the action. - Adds input validation, debug logging, error handling, and PR comment creation/updating in the composite action.
- Switches to
awkfor coverage parsing and ensures failures are surfaced correctly.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/ci.yaml | Limit push events to main and supply the github-token input for PR comment operations. |
| .github/actions/check-coverage/action.yaml | Add token input, validations, debug logs, AWK-based parsing, and PR comment logic. |
Comments suppressed due to low confidence (1)
.github/workflows/ci.yaml:1
- This workflow uses the action to post PR comments but doesn’t grant the necessary
pull-requests: writepermission to the GITHUB_TOKEN. Please add apermissions:block (e.g.,permissions: pull-requests: write) at the top of this workflow to ensure the action can create and update comments.
name: CI
zkfriendly
approved these changes
Jun 30, 2025
benceharomi
deleted the
bence/sol-169-update-check-coverage-ci-in-email-as-ens
branch
benceharomi
added a commit
that referenced
this pull request
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the check-coverage CI job with the improved version: zkemail/solidity-template#2