feat: Add Truist provider with Zelle template file#81
feat: Add Truist provider with Zelle template file#81daniel0ar wants to merge 2 commits intozkp2p:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8c914fa85e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| }, | ||
| { | ||
| "type": "regex", | ||
| "value": "\"pendingStatus\":\"(?<pendingStatus>[^\"]+)\"" |
There was a problem hiding this comment.
The pendingStatus matcher currently accepts any value, so a proof can still pass for non-finalized activities (for example pending/canceled entries) as long as other fields match. For a transfer_zelle template, this weakens correctness because unsettled transactions can be treated as completed transfers. Constrain this predicate to finalized status value(s) from Truist or add an explicit non-pending check.
Useful? React with 👍 / 👎.
| "fallbackMethod": "", | ||
| "preprocessRegex": "", | ||
| "transactionsExtraction": { | ||
| "transactionJsonPathListSelector": "$.postedActivities", |
There was a problem hiding this comment.
This template reads the full postedActivities list from an endpoint named all-activities but does not add any outbound-direction predicate in the matching rules. If the feed contains both sent and received Zelle events, incoming activity can be selected and proven under transfer_zelle, producing incorrect transfer semantics. Add a direction/status filter at request or response-match level so only outbound transfers are eligible.
Useful? React with 👍 / 👎.
1 participant
Overview
This branch adds the json template file for a Truist with Zelle new provider. The development has been supervised by @richardliang . Please do check it out in case I'm still missing something (eg. headers, fields or any other field).