Open
Conversation
Maddiaa0
changed the title
Maddiaa0
force-pushed
the
md/bench-opcode-counts
branch
2 times, most recently
from
9f22aaa to
7a548ee
Compare
Maddiaa0
force-pushed
the
md/bench-opcode-counts
branch
from
7a548ee to
a9c4b06
Compare
Maddiaa0
force-pushed
the
md/bench-opcode-counts
branch
from
c14237d to
bf0805e
Compare
Contributor
|
Love this idea! Although unfortunately it ended up tripling the CI run time. It's also currently only checking the circuits used in integration tests, so we're not seeing gate counts for the full set, which would take even longer to process. One thing that could help: caching gate counts to disk using a filename based on a hash of the flattened Noir code, along with the nargo and bb versions. That way, if nothing has changed we can skip recalculating the gate count and hopefully speed up CI quite a bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The first part of this pr includes making infra to store the output of the nargo info command, so that it can be compared against main when making changes to the circuits