Skip to content

Export pageable interface to ease up mocking #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ebreiner wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Export pageable interface to ease up mocking #260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions page.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,15 +107,15 @@ type SimpleShowPage struct {
Shows []FullShow `json:"items"`
}

// pageable is an internal interface for types that support paging
// Pageable is an interface for types that support paging
// by embedding basePage.
type pageable interface{ canPage() }
type Pageable interface{ CanPage() }

func (b *basePage) canPage() {}
func (b *basePage) CanPage() {}

// NextPage fetches the next page of items and writes them into p.
// It returns ErrNoMorePages if p already contains the last page.
func (c *Client) NextPage(ctx context.Context, p pageable) error {
func (c *Client) NextPage(ctx context.Context, p Pageable) error {
if p == nil || reflect.ValueOf(p).IsNil() {
return fmt.Errorf("spotify: p must be a non-nil pointer to a page")
}
Expand All @@ -139,7 +139,7 @@ func (c *Client) NextPage(ctx context.Context, p pageable) error {

// PreviousPage fetches the previous page of items and writes them into p.
// It returns ErrNoMorePages if p already contains the last page.
func (c *Client) PreviousPage(ctx context.Context, p pageable) error {
func (c *Client) PreviousPage(ctx context.Context, p Pageable) error {
if p == nil || reflect.ValueOf(p).IsNil() {
return fmt.Errorf("spotify: p must be a non-nil pointer to a page")
}
Expand Down