fix dir order - otherwise mixing between zmk-config and built-ins breaks

[petejohanson]

Ok, so this is a rework of #24 that does things now in two phases:

• Iterates all the board roots, gathering the details of all the shields found therein.
• Iterates the requested shields, finding them from the collected shield info from the first phase.

Doing so should preserve the ordering when adding DTS, config files, etc., but also properly sets up the collection of available shields for use in the "list unfound shield" piece.

[petejohanson]

@Percentnineteen Please give this a try. I tweaked your idea a bit to split into two phases, which seems to work for the specific bug fix you were shooting to fix, and still works as expected when no shields are passed in, which caused issues with your original version. Thanks again for the fix!

[petejohanson]

Ok, so feeling confident about this; I should have done this testing before: I created a ZMK draft PR that uses this specific Zephyr branch and the builds all pass fine: zmkfirmware/zmk#1981

Also tested several of my user config repos against that ZMK branch, with no issues.

[Percentnineteen]

Sorry. I didn't think of the case where no shields were passed in. I won't have any time to dig in but if it seems to work, I'm happy.

…

On Sun, Oct 29, 2023, 9:55 AM Pete Johanson ***@***.***> wrote: Ok, so feeling confident about this; I should have done this testing before: I created a ZMK draft PR that uses this specific Zephyr branch and the builds all pass fine: zmkfirmware/zmk#1981 <zmkfirmware/zmk#1981> Also tested several of my user config repos against that ZMK branch, with no issues. — Reply to this email directly, view it on GitHub <#26 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC4HWRB37CAGJJNKMF5HEN3YBZU4PAVCNFSM6AAAAAA6USJLJWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBUGEZTKOBZGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>