Inject an instantiated persistence handler.#53
Open
mogilvie wants to merge 10 commits intozoho:masterfrom
Open
Inject an instantiated persistence handler.#53mogilvie wants to merge 10 commits intozoho:masterfrom
mogilvie wants to merge 10 commits intozoho:masterfrom
Conversation
|
Hi, This is exactly the feature I was searching for but couldn't find in the current code. I hope this feature is merged into this library soon! |
phil-schreiber
approved these changes
Sep 9, 2020
|
Is there any way we can support to get this merged? |
Author
|
Do I need to do anything else here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, the current method of creating a custom persistence handler doest allow the developer access to the constructor or setter methods.
Instead, consider injecting a custom persistence handler. I've done this by adding the custom handler to the config array at run time.
Although better yet would be a setter method.