Skip to content

Show specific missing profile fields instead of generic incomplete-profile error#91

Closed
Copilot wants to merge 3 commits intodevfrom
copilot/update-complete-profile-message
Closed

Show specific missing profile fields instead of generic incomplete-profile error#91
Copilot wants to merge 3 commits intodevfrom
copilot/update-complete-profile-message

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 10, 2026

The "Complete your profile before browsing" error gave users no indication of what was actually missing. Users now see exactly which fields need to be filled in.

Changes

  • Backend (browsing.ts): On PROFILE_INCOMPLETE, queries the actual field values and photo count to build a missingFields: string[] list, returned in the error details:

    {
      "error": {
        "code": "PROFILE_INCOMPLETE",
        "details": { "missingFields": ["biography", "photos"] }
      }
    }
  • Types (types/api.ts, errors/ApiError.ts): Widened details from string to unknown to accommodate structured payloads.

  • ProfileIncompleteNotice: Accepts missingFields?: string[] and renders a labelled list with human-readable names (sexual_preference → "Sexual preference", birth_date → "Date of birth", etc.). Falls back to the previous generic message when no fields are provided.

  • Feed page (feed/page.tsx): Extracts missingFields from the error details and passes it to ProfileIncompleteNotice. Simplified the PROFILE_INCOMPLETE detection to rely solely on error.code.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • fonts.googleapis.com
    • Triggering command: /opt/hostedtoolcache/node/24.14.0/x64/bin/node /opt/hostedtoolcache/node/24.14.0/x64/bin/node /home/REDACTED/work/Matcha/Matcha/node_modules/.pnpm/next@15.5.5_@babel+core@7.29.0_react-dom@19.1.0_react@19.1.0__react@19.1.0/node_modules/next/dist/compiled/jest-worker/processChild.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>Completed profiles</issue_title>
<issue_description>Please be more specific. The user should know exactly what is missing. The generic message, "Complete your profile before browsing," is not specific enough</issue_description>

<agent_instructions>Might the luck be on your side</agent_instructions>

Comments on the Issue (you are @copilot in this section)

@LuckyIntegral Once the message is updated, frontend should also change the view of the feed (it is on me)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: LuckyIntegral <110788165+LuckyIntegral@users.noreply.github.com>
Copilot AI changed the title [WIP] Update profile completion message for clarity Show specific missing profile fields instead of generic incomplete-profile error Mar 10, 2026
@LuckyIntegral
Copy link
Copy Markdown
Collaborator

LGTM, please check it as well @zolfagharipour

@LuckyIntegral LuckyIntegral marked this pull request as ready for review March 11, 2026 13:01
@LuckyIntegral LuckyIntegral reopened this Mar 11, 2026
@LuckyIntegral
Copy link
Copy Markdown
Collaborator

The issue form the pr is not resolved, please look at once you have time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Completed profiles

3 participants