Show specific missing profile fields instead of generic incomplete-profile error#91
Closed
Show specific missing profile fields instead of generic incomplete-profile error#91
Conversation
Co-authored-by: LuckyIntegral <110788165+LuckyIntegral@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update profile completion message for clarity
Show specific missing profile fields instead of generic incomplete-profile error
Mar 10, 2026
Collaborator
|
LGTM, please check it as well @zolfagharipour |
Collaborator
|
The issue form the pr is not resolved, please look at once you have time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Complete your profile before browsing" error gave users no indication of what was actually missing. Users now see exactly which fields need to be filled in.
Changes
Backend (
browsing.ts): OnPROFILE_INCOMPLETE, queries the actual field values and photo count to build amissingFields: string[]list, returned in the errordetails:{ "error": { "code": "PROFILE_INCOMPLETE", "details": { "missingFields": ["biography", "photos"] } } }Types (
types/api.ts,errors/ApiError.ts): Wideneddetailsfromstringtounknownto accommodate structured payloads.ProfileIncompleteNotice: AcceptsmissingFields?: string[]and renders a labelled list with human-readable names (sexual_preference→ "Sexual preference",birth_date→ "Date of birth", etc.). Falls back to the previous generic message when no fields are provided.Feed page (
feed/page.tsx): ExtractsmissingFieldsfrom the error details and passes it toProfileIncompleteNotice. Simplified thePROFILE_INCOMPLETEdetection to rely solely onerror.code.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
fonts.googleapis.com/opt/hostedtoolcache/node/24.14.0/x64/bin/node /opt/hostedtoolcache/node/24.14.0/x64/bin/node /home/REDACTED/work/Matcha/Matcha/node_modules/.pnpm/next@15.5.5_@babel+core@7.29.0_react-dom@19.1.0_react@19.1.0__react@19.1.0/node_modules/next/dist/compiled/jest-worker/processChild.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.