-
Notifications
You must be signed in to change notification settings - Fork 42
fix: combined coverage report #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
e352897 to
579c0b1
Compare
579c0b1 to
95272c2
Compare
|
When using the matrix execution we can not collect the combined coverage from each python version. |
|
https://hynek.me/articles/ditch-codecov-python/ has a suggestion of how to do this |
3eeac16 to
9730e11
Compare
|
FYI, the file |
619000e to
338da05
Compare
Build job: - add upload artifact step after each test in the matrix. - update coveralls step to upload partial data. Converage job (new): - complete the coveralls in the coverage job. - add step to download all uploaded artifacts - add step to combine coverage data, create report and fail if not enough - add step to upload html report if coverage is not enough
338da05 to
f3704f2
Compare
Thank you @dataflake for the reminder. Yes, I know that this should not be changed directly. I will convert this PR to a draft to avoid confusion. |
|
I think this approach presented here is promising. It requires some changes in I currently do not have the time and energy to push |
Currently, we have some issues regarding the combined coverage:
combined-coveragesection does not work because of the order of thecoveragesection that runs beforecoveragesection is used in the CI together with coveralls but it only checks with one Python version meaning it can not enforce it to be 100% because i.e: https://coveralls.io/jobs/107753481This PR is a POC to try to find a better way to implement both, the local coverage check and the CI one.
** I',m aware that these files are autogenerated by the meta package. If we agree that this makes sense I would like to propose the creation of new templates in the meta package to handle this use case. **
Here follow all the changes I implemented:
Tox:
CI:
Next step:
coverage combinemeta#33).meta.tomlto use the new template/options and generate the files creating the final PR