draft for STCS test cases by Himani1519 · Pull Request #230 · zowe/zen

Himani1519 · 2024-07-18T12:47:54Z

Proposed changes

This PR addresses Issue: [Link to Github issue within https://github.com/zowe/zen/issues if any]

This PR depends upon the following PRs:

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Change in a documentation
Refactor the code
Chore, repository cleanup, updates the dependencies.
Breaking change (fix or feature that would cause existing functionality to not work as expected)

PR Checklist

Please delete options that are not relevant.

If the changes in this PR are meant for the next release / mainline, this PR targets a "staging" branch.
My code follows the style guidelines of this project (see: Contributing guideline)
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
New and existing unit tests pass locally with my changes
video or image is included if visual changes are made

My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works, or describe a test method below

Testing

Further comments

Signed-off-by: Himani1519 <paripathak80@gmail.com>

sagar-1310

Please have a look and update the code. Please let me know if you have any ques.

sagar-1310 · 2024-08-01T11:35:14Z

playwright_test/Pages/connection.page.ts

    return await this.greenCheckIconSelector.isHidden();
  }
+
+  async click_resumeProgress(){


This function should be in the Title page file and already exists so you can use it from there.

sagar-1310 · 2024-08-01T11:41:51Z

playwright_test/Pages/installationType.page.ts

-  } 
+  }
+
+  async clickOnContinueToUnpax(){


As we have a separate page for Unpax, I think we can add all unpax-related stuff under unpax page file.

We don't have unpax page as of now.

Correct, we don't have the page with the title 'Unpax' but on the 'Installation Type' page we are getting the option to 'Continue to Unpax' page, and on that page, we are getting the option 'Skip Unpax' so I think that is a page but it doesn't have the specific title as the title depends on which Installation type we are selecting. So I think if we are following the Page object model then we should add the 'Unpax' page separately. Let me know your thoughts or we can discuss this with our QA team.

I agree as your new PR contains unpax page so will wait for your PR to merge then after that I will fix them after taking pull, because writing same code in two files does not make sense.

sagar-1310 · 2024-08-01T11:43:42Z

playwright_test/Pages/security.page.ts

-    this.mainXpath = '//html/body/div/div[2]/div/div[4]/div/form/div/div[3]/div[1]/div[3]/div/div[2]/div/div/div'
-    this.stc_mainXpath = '//html/body/div[1]/div[2]/div/div[4]/div/form/div/div[3]/div[1]/div[4]/div/div[2]/div/div/div/'
+    this.mainXpath = '//html/body/div/div[2]/div/div[4]/div/form/div/div[2]/div[1]/div[3]/div/div[2]/div/div/div'
+    this.stc_mainXpath = '//html/body/div/div[2]/div/div[4]/div/form/div/div[2]/div[1]/div[4]/div/div[2]/div/div/div'


Avoid using dynamic xpaths which changes frequently

sagar-1310 · 2024-08-01T11:53:33Z

playwright_test/Pages/stcs.page.ts

+
+
+
+  constructor(page: Page) {


You have initialized locators under Constructor but you haven't added page objects for them under class. So if you see there are 20 page objects under class, but under Constructor there are more than 30 you initialized. And by using the same locators you have created methods so it does not make sense. It causes failure of tests. Please have a look and update them.

sagar-1310 · 2024-08-01T12:04:53Z

playwright_test/Tests/Stcs.spec.ts

@@ -0,0 +1,254 @@
+import { test, ElectronApplication, expect, _electron as electron } from '@playwright/test';


All the test cases are failing for me due to the issues in the Page object file so needs to be repaired.

Its running test cases selecting SMP/E installation type so whatever the runtime dir you are passing should be exist already on rs28. For me all test cases are getting passed.

sagar-1310 · 2024-08-01T12:08:06Z

playwright_test/Tests/Stcs.spec.ts

+const LOAD_LIB = process.env.LOAD_LIB;
+const AUTH_LOAD_LIB = process.env.AUTH_LOAD_LIB;
+const AUTH_PLUGIN_LIB = process.env.AUTH_PLUGIN_LIB;
+const UPLOAD_PAX_PATH = process.env.ZOWE_ROOT_DIR


Remove unused declaration.

we are using them at this line https://github.com/zowe/zen/pull/230/files#diff-3ec40a03d28e9024612ae4af658741981a84c2c55f9e6a816f3f493218c5b590

I am not able to see if you used UPLOAD_PAX_PATH anywhere.

sagar-1310 · 2024-08-01T12:08:21Z

playwright_test/Tests/Stcs.spec.ts

+    await page.waitForTimeout(30000);
+    installationTypePage.clickSkipUnpaxButton()
+    await page.waitForTimeout(2000);
+//     installationTypePage.clickContinueToInstallation()


Remove commented code.

sagar-1310 · 2024-08-01T12:10:33Z

playwright_test/Tests/Stcs.spec.ts

+
+   test('test all required fields', async ({ page }) => {
+    await page.waitForTimeout(5000);
+    await expect(stcsPage.zis).toBeTruthy()


Remove the unwanted 'await' statement as the 'await' does not affect the expect statements.

Adding wait so that page loaded successfully and then we can check expected result.

That is fine but I mean to say if you use await in expect statement, it does not affect the result. So if you see in the same file for many expect statements, you haven't used 'await'. So I was asking to remove it if it is not necessary.

Signed-off-by: Himani1519 <paripathak80@gmail.com>

sagar-1310

Approved but not ready to merge. We will merge after James's PR will get merged with updated test logics.

Himani1519 added 2 commits July 18, 2024 18:03

draft for STCS test cases

1a75f5e

Signed-off-by: Himani1519 <paripathak80@gmail.com>

fixed test cases

8191b56

Signed-off-by: Himani1519 <paripathak80@gmail.com>

sagar-1310 self-requested a review August 1, 2024 11:32

sagar-1310 requested changes Aug 1, 2024

View reviewed changes

few fixes

79a31e8

Signed-off-by: Himani1519 <paripathak80@gmail.com>

sagar-1310 approved these changes Aug 5, 2024

View reviewed changes

		@@ -0,0 +1,254 @@
		import { test, ElectronApplication, expect, _electron as electron } from '@playwright/test';

Conversation

Himani1519 commented Jul 18, 2024

Proposed changes

Type of change

PR Checklist

Testing

Further comments

Uh oh!

sagar-1310 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sagar-1310 Aug 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sagar-1310 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sagar-1310 Aug 1, 2024 •

edited

Loading