Skip to content

Use zsa/defaults module in Moonlander keymaps#423

Open
J3RN wants to merge 1 commit intozsa:firmware25from
J3RN:zsa/defaults
Open

Use zsa/defaults module in Moonlander keymaps#423
J3RN wants to merge 1 commit intozsa:firmware25from
J3RN:zsa/defaults

Conversation

@J3RN
Copy link
Copy Markdown

@J3RN J3RN commented Dec 30, 2025

Description

I was unable to compile the Moonlander layouts until I added the zsa/defaults module to each keymap.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • N/A

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@phewphewb
Copy link
Copy Markdown

yup, same here, looks like they build with Oryx internally. Also it requires a pre 3.14 python

Copy link
Copy Markdown

@ghthor ghthor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm, this fixed my moonlander build and was able to compile using qmk command

qmk compile -kb zsa/moonlander/revb -km default

Applying a the same also enabled me to build for my ergodox ez

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants