Skip to content

add check to fbq instance #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sam1g wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add check to fbq instance #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57256ca
fix window undefined
juanlatorre May 14, 2022
4725678
add check to fbqfbq instance
sam1g Jan 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/fb-pixel.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/fb-pixel.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

52 changes: 26 additions & 26 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
{
"name": "react-facebook-pixel",
"version": "1.0.4",
"name": "@juanlatorre/react-facebook-pixel",
"version": "1.0.5",
"description": "Pixel Kit for React",
"main": "dist/fb-pixel.js",
"types": "./types/index.d.ts",
"scripts": {
"start": "export NODE_ENV=development&& webpack-dev-server --config webpack.config.dev.js",
"bundle": "export NODE_ENV=production&& webpack -p --config webpack.config.dist.js",
"start": "export NODE_ENV=development && webpack-dev-server --config webpack.config.dev.js",
"bundle": "export NODE_ENV=production && webpack --config webpack.config.dist.js",
"lint": "eslint --ignore-path .gitignore --fix",
"lint:staged": "lint-staged",
"clean": "rm -rf node_modules",
Expand All @@ -33,28 +33,28 @@
"homepage": "https://github.com/zsajjad/react-facebook-pixel",
"dependencies": {},
"devDependencies": {
"@babel/core": "^7.7.5",
"@babel/plugin-transform-react-constant-elements": "^7.7.4",
"@babel/plugin-transform-react-inline-elements": "^7.7.4",
"@babel/preset-env": "^7.7.6",
"autoprefixer": "9.7.3",
"babel-eslint": "10.0.3",
"babel-loader": "^8.0.6",
"eslint": "6.7.2",
"eslint-config-airbnb": "18.0.1",
"eslint-config-prettier": "^6.7.0",
"eslint-plugin-import": "2.19.1",
"eslint-plugin-jsx-a11y": "6.2.3",
"eslint-plugin-prettier": "^3.1.1",
"eslint-plugin-react": "7.17.0",
"eslint-plugin-react-hooks": "^2.3.0",
"lint-staged": "^9.5.0",
"prettier": "^1.19.1",
"react": "^16.12.0",
"react-dom": "^16.12.0",
"webpack": "4.41.2",
"webpack-cli": "^3.3.10",
"webpack-dev-server": "3.9.0"
"@babel/core": "7.17.8",
"@babel/plugin-transform-react-constant-elements": "7.17.6",
"@babel/plugin-transform-react-inline-elements": "7.16.7",
"@babel/preset-env": "7.16.11",
"autoprefixer": "10.4.4",
"babel-eslint": "10.1.0",
"babel-loader": "8.2.4",
"eslint": "8.12.0",
"eslint-config-airbnb": "19.0.4",
"eslint-config-prettier": "8.5.0",
"eslint-plugin-import": "2.25.4",
"eslint-plugin-jsx-a11y": "6.5.1",
"eslint-plugin-prettier": "4.0.0",
"eslint-plugin-react": "7.29.4",
"eslint-plugin-react-hooks": "4.4.0",
"lint-staged": "12.3.7",
"prettier": "2.6.1",
"react": "18.0.0",
"react-dom": "18.0.0",
"webpack": "5.71.0",
"webpack-cli": "4.9.2",
"webpack-dev-server": "4.7.4"
},
"peerDependencies": {},
"lint-staged": {
Expand Down
80 changes: 44 additions & 36 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,44 +55,52 @@ const defaultOptions = {
//
export default {
init(pixelId, advancedMatching = {}, options = defaultOptions) {
initialized = (typeof window !== 'undefined') && !!window.fbq;
/* eslint-disable */
!(function(f, b, e, v, n, t, s) {
if (f.fbq) return;
n = f.fbq = function() {
n.callMethod
? n.callMethod.apply(n, arguments)
: n.queue.push(arguments);
};
if (!f._fbq) f._fbq = n;
n.push = n;
n.loaded = !0;
n.version = '2.0';
n.queue = [];
t = b.createElement(e);
t.async = !0;
t.src = v;
s = b.getElementsByTagName(e)[0];
s.parentNode.insertBefore(t, s);
})(
window,
document,
'script',
'https://connect.facebook.net/en_US/fbevents.js',
);
/* eslint-enable */
if (typeof window === 'undefined') {
initialized = false;
return;
}

if (!pixelId) {
warn('Please insert pixel id for initializing');
} else {
if (options.autoConfig === false) {
fbq('set', 'autoConfig', false, pixelId); // eslint-disable-line no-undef
initialized = window && !!window.fbq;
/* eslint-disable */
const fbq = window?.fbq;
if (typeof fbq === 'undefined') {
!(function (f, b, e, v, n, t, s) {
if (f.fbq) return;
n = f.fbq = function () {
n.callMethod
? n.callMethod.apply(n, arguments)
: n.queue.push(arguments);
};
if (!f._fbq) f._fbq = n;
n.push = n;
n.loaded = !0;
n.version = '2.0';
n.queue = [];
t = b.createElement(e);
t.async = !0;
t.src = v;
s = b.getElementsByTagName(e)[0];
s.parentNode.insertBefore(t, s);
})(
window,
document,
'script',
'https://connect.facebook.net/en_US/fbevents.js',
);
/* eslint-enable */

if (!pixelId) {
warn('Please insert pixel id for initializing');
} else {
if (options.autoConfig === false) {
fbq('set', 'autoConfig', false, pixelId); // eslint-disable-line no-undef
}

fbq('init', pixelId, advancedMatching); // eslint-disable-line no-undef

initialized = true;
debug = options.debug;
}

fbq('init', pixelId, advancedMatching); // eslint-disable-line no-undef

initialized = true;
debug = options.debug;
}
},

Expand Down
1 change: 1 addition & 0 deletions webpack.config.dist.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ module.exports = {
filename: 'fb-pixel.js',
libraryTarget: 'umd',
library: 'ReactPixel',
globalObject: 'this',
},
module: {
rules: [
Expand Down
Loading