Skip to content

Update type hints for Cloud Firewall #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update type hints for Cloud Firewall #417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1cf70a1
Add correct type hinting for list_rules
Chrigiii Nov 11, 2025
eb1d007
Update return type of list_rules method
Chrigiii Nov 11, 2025
b740b6a
Change return type of list_rules to APIResult[List[FirewallIPSrules]]
Chrigiii Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion zscaler/zia/cloud_firewall_dns.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def __init__(self, request_executor: "RequestExecutor") -> None:
def list_rules(
self,
query_params: Optional[dict] = None,
) -> APIResult[dict]:
) -> APIResult[List[FirewallDNSRules]]:
"""
List firewall dns rules in your organization.
If the `search` parameter is provided, the function filters the rules client-side.
Expand Down
2 changes: 1 addition & 1 deletion zscaler/zia/cloud_firewall_ips.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def __init__(self, request_executor: "RequestExecutor") -> None:
def list_rules(
self,
query_params: Optional[dict] = None,
) -> APIResult[dict]:
) -> APIResult[List[FirewallIPSrules]]:
"""
List firewall ips rules in your organization.
If the `search` parameter is provided, the function filters the rules client-side.
Expand Down
2 changes: 1 addition & 1 deletion zscaler/zia/cloud_firewall_rules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def __init__(self, request_executor: "RequestExecutor") -> None:
def list_rules(
self,
query_params: Optional[dict] = None,
) -> APIResult[dict]:
) -> APIResult[List[FirewallRule]]:
"""
List firewall rules in your organization.
If the `search` parameter is provided, the function filters the rules client-side.
Expand Down