Update documentation to clarify bats-assert loading#13
Open
jhart-r7 wants to merge 1 commit intoztombol:masterfrom
Open
Update documentation to clarify bats-assert loading#13jhart-r7 wants to merge 1 commit intoztombol:masterfrom
jhart-r7 wants to merge 1 commit intoztombol:masterfrom
Conversation
Contributor
|
I think we should probably even consider replacing git submodules with git subtrees* as the recommended installation option (as subtrees require a lot less management bookkeeping than submodules.) in addition to this PR, not instead of |
Author
|
Yes, in reading up on subtrees I agree that might be a good alternative in the future, but for now (to your point) I think this PR would be helpful to land. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this documentation there was some inconsistency with regards to which
batssupporting libraries were being referred to. The result was that if you followed this verbatim for the common github submodule case, many of the asserts wouldn't work and it might not be immediately obvious why. This PR updates the documentation to be more consistent in this regard -- now bothbats-supportandbats-assertare both always referenced.