Skip to content

msglist: Support viewing who reacted to a message #1700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 2, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified assets/icons/ZulipIcons.ttf
Binary file not shown.
6 changes: 6 additions & 0 deletions assets/icons/see_who_reacted.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
50 changes: 50 additions & 0 deletions assets/l10n/app_en.arb
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,37 @@
"@errorUnresolveTopicFailedTitle": {
"description": "Error title when marking a topic as unresolved failed."
},
"actionSheetOptionSeeWhoReacted": "See who reacted",
"@actionSheetOptionSeeWhoReacted": {
"description": "Label for the 'See who reacted' button in the message action sheet."
},
"seeWhoReactedSheetNoReactions": "This message has no reactions.",
"@seeWhoReactedSheetNoReactions": {
"description": "Explanation on the 'See who reacted' sheet when the message has no reactions (because they were removed after the sheet was opened)."
},
"seeWhoReactedSheetHeaderLabel": "Emoji reactions ({num} total)",
"@seeWhoReactedSheetHeaderLabel": {
"description": "In the 'See who reacted' sheet, a label for the list of emoji reactions at the top, with the total number of reactions. (An accessibility label for assistive technology.)",
"placeholders": {
"num": {"type": "int", "example": "2"}
}
},
"seeWhoReactedSheetEmojiNameWithVoteCount": "{emojiName}: {num, plural, =1{1 vote} other{{num} votes}}",
"@seeWhoReactedSheetEmojiNameWithVoteCount": {
"description": "In the 'See who reacted' sheet, an emoji reaction's name and how many votes it has. (An accessibility label for assistive technology.)",
"placeholders": {
"emojiName": {"type": "String", "example": "working_on_it"},
"num": {"type": "int", "example": "2"}
}
},
"seeWhoReactedSheetUserListLabel": "Votes for {emojiName} ({num})",
"@seeWhoReactedSheetUserListLabel": {
"description": "In the 'See who reacted' sheet, a label for the list of users who chose an emoji reaction, with the emoji's name and how many votes it has. (An accessibility label for assistive technology.)",
"placeholders": {
"emojiName": {"type": "String", "example": "working_on_it"},
"num": {"type": "int", "example": "2"}
}
},
"actionSheetOptionCopyMessageText": "Copy message text",
"@actionSheetOptionCopyMessageText": {
"description": "Label for copy message text button on action sheet."
Expand Down Expand Up @@ -973,6 +1004,25 @@
"@reactedEmojiSelfUser": {
"description": "Display name for the user themself, to show on an emoji reaction added by the user."
},
"reactionChipsLabel": "Reactions",
"@reactionChipsLabel": {
"description": "Text identifying the container of reaction chips on a message. (An accessibility label for assistive technology.)"
},
"reactionChipLabel": "{emojiName}: {votes}",
"@reactionChipLabel": {
"description": "Text describing a reaction chip, with the emoji name and a list or number of votes. (An accessibility label for assistive technology.)",
"placeholders": {
"emojiName": {"type": "String", "example": "working_on_it"},
"votes": {"type": "String", "example": "You, Chris, Greg"}
}
},
"reactionChipVotesYouAndOthers": "{otherUsersCount, plural, =1{You and 1 other} other{You and {otherUsersCount} others}}",
"@reactionChipVotesYouAndOthers": {
"description": "The number of votes on a reaction chip, where the self-user and at least one other user has voted. (An accessibility label for assistive technology.)",
"placeholders": {
"otherUsersCount": {"type": "int", "example": "4"}
}
},
"onePersonTyping": "{typist} is typing…",
"@onePersonTyping": {
"description": "Text to display when there is one user typing.",
Expand Down
48 changes: 48 additions & 0 deletions lib/generated/l10n/zulip_localizations.dart
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,36 @@ abstract class ZulipLocalizations {
/// **'Failed to mark topic as unresolved'**
String get errorUnresolveTopicFailedTitle;

/// Label for the 'See who reacted' button in the message action sheet.
///
/// In en, this message translates to:
/// **'See who reacted'**
String get actionSheetOptionSeeWhoReacted;

/// Explanation on the 'See who reacted' sheet when the message has no reactions (because they were removed after the sheet was opened).
///
/// In en, this message translates to:
/// **'This message has no reactions.'**
String get seeWhoReactedSheetNoReactions;

/// In the 'See who reacted' sheet, a label for the list of emoji reactions at the top, with the total number of reactions. (An accessibility label for assistive technology.)
///
/// In en, this message translates to:
/// **'Emoji reactions ({num} total)'**
String seeWhoReactedSheetHeaderLabel(int num);

/// In the 'See who reacted' sheet, an emoji reaction's name and how many votes it has. (An accessibility label for assistive technology.)
///
/// In en, this message translates to:
/// **'{emojiName}: {num, plural, =1{1 vote} other{{num} votes}}'**
String seeWhoReactedSheetEmojiNameWithVoteCount(String emojiName, int num);

/// In the 'See who reacted' sheet, a label for the list of users who chose an emoji reaction, with the emoji's name and how many votes it has. (An accessibility label for assistive technology.)
///
/// In en, this message translates to:
/// **'Votes for {emojiName} ({num})'**
String seeWhoReactedSheetUserListLabel(String emojiName, int num);

/// Label for copy message text button on action sheet.
///
/// In en, this message translates to:
Expand Down Expand Up @@ -1469,6 +1499,24 @@ abstract class ZulipLocalizations {
/// **'You'**
String get reactedEmojiSelfUser;

/// Text identifying the container of reaction chips on a message. (An accessibility label for assistive technology.)
///
/// In en, this message translates to:
/// **'Reactions'**
String get reactionChipsLabel;

/// Text describing a reaction chip, with the emoji name and a list or number of votes. (An accessibility label for assistive technology.)
///
/// In en, this message translates to:
/// **'{emojiName}: {votes}'**
String reactionChipLabel(String emojiName, String votes);

/// The number of votes on a reaction chip, where the self-user and at least one other user has voted. (An accessibility label for assistive technology.)
///
/// In en, this message translates to:
/// **'{otherUsersCount, plural, =1{You and 1 other} other{You and {otherUsersCount} others}}'**
String reactionChipVotesYouAndOthers(int otherUsersCount);

/// Text to display when there is one user typing.
///
/// In en, this message translates to:
Expand Down
46 changes: 46 additions & 0 deletions lib/generated/l10n/zulip_localizations_ar.dart
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,33 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
String get errorUnresolveTopicFailedTitle =>
'Failed to mark topic as unresolved';

@override
String get actionSheetOptionSeeWhoReacted => 'See who reacted';

@override
String get seeWhoReactedSheetNoReactions => 'This message has no reactions.';

@override
String seeWhoReactedSheetHeaderLabel(int num) {
return 'Emoji reactions ($num total)';
}

@override
String seeWhoReactedSheetEmojiNameWithVoteCount(String emojiName, int num) {
String _temp0 = intl.Intl.pluralLogic(
num,
locale: localeName,
other: '$num votes',
one: '1 vote',
);
return '$emojiName: $_temp0';
}

@override
String seeWhoReactedSheetUserListLabel(String emojiName, int num) {
return 'Votes for $emojiName ($num)';
}

@override
String get actionSheetOptionCopyMessageText => 'Copy message text';

Expand Down Expand Up @@ -796,6 +823,25 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
@override
String get reactedEmojiSelfUser => 'You';

@override
String get reactionChipsLabel => 'Reactions';

@override
String reactionChipLabel(String emojiName, String votes) {
return '$emojiName: $votes';
}

@override
String reactionChipVotesYouAndOthers(int otherUsersCount) {
String _temp0 = intl.Intl.pluralLogic(
otherUsersCount,
locale: localeName,
other: 'You and $otherUsersCount others',
one: 'You and 1 other',
);
return '$_temp0';
}

@override
String onePersonTyping(String typist) {
return '$typist is typing…';
Expand Down
46 changes: 46 additions & 0 deletions lib/generated/l10n/zulip_localizations_de.dart
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,33 @@ class ZulipLocalizationsDe extends ZulipLocalizations {
String get errorUnresolveTopicFailedTitle =>
'Thema konnte nicht als ungelöst markiert werden';

@override
String get actionSheetOptionSeeWhoReacted => 'See who reacted';

@override
String get seeWhoReactedSheetNoReactions => 'This message has no reactions.';

@override
String seeWhoReactedSheetHeaderLabel(int num) {
return 'Emoji reactions ($num total)';
}

@override
String seeWhoReactedSheetEmojiNameWithVoteCount(String emojiName, int num) {
String _temp0 = intl.Intl.pluralLogic(
num,
locale: localeName,
other: '$num votes',
one: '1 vote',
);
return '$emojiName: $_temp0';
}

@override
String seeWhoReactedSheetUserListLabel(String emojiName, int num) {
return 'Votes for $emojiName ($num)';
}

@override
String get actionSheetOptionCopyMessageText => 'Nachrichtentext kopieren';

Expand Down Expand Up @@ -816,6 +843,25 @@ class ZulipLocalizationsDe extends ZulipLocalizations {
@override
String get reactedEmojiSelfUser => 'Du';

@override
String get reactionChipsLabel => 'Reactions';

@override
String reactionChipLabel(String emojiName, String votes) {
return '$emojiName: $votes';
}

@override
String reactionChipVotesYouAndOthers(int otherUsersCount) {
String _temp0 = intl.Intl.pluralLogic(
otherUsersCount,
locale: localeName,
other: 'You and $otherUsersCount others',
one: 'You and 1 other',
);
return '$_temp0';
}

@override
String onePersonTyping(String typist) {
return '$typist tippt…';
Expand Down
46 changes: 46 additions & 0 deletions lib/generated/l10n/zulip_localizations_en.dart
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,33 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
String get errorUnresolveTopicFailedTitle =>
'Failed to mark topic as unresolved';

@override
String get actionSheetOptionSeeWhoReacted => 'See who reacted';

@override
String get seeWhoReactedSheetNoReactions => 'This message has no reactions.';

@override
String seeWhoReactedSheetHeaderLabel(int num) {
return 'Emoji reactions ($num total)';
}

@override
String seeWhoReactedSheetEmojiNameWithVoteCount(String emojiName, int num) {
String _temp0 = intl.Intl.pluralLogic(
num,
locale: localeName,
other: '$num votes',
one: '1 vote',
);
return '$emojiName: $_temp0';
}

@override
String seeWhoReactedSheetUserListLabel(String emojiName, int num) {
return 'Votes for $emojiName ($num)';
}

@override
String get actionSheetOptionCopyMessageText => 'Copy message text';

Expand Down Expand Up @@ -796,6 +823,25 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
@override
String get reactedEmojiSelfUser => 'You';

@override
String get reactionChipsLabel => 'Reactions';

@override
String reactionChipLabel(String emojiName, String votes) {
return '$emojiName: $votes';
}

@override
String reactionChipVotesYouAndOthers(int otherUsersCount) {
String _temp0 = intl.Intl.pluralLogic(
otherUsersCount,
locale: localeName,
other: 'You and $otherUsersCount others',
one: 'You and 1 other',
);
return '$_temp0';
}

@override
String onePersonTyping(String typist) {
return '$typist is typing…';
Expand Down
46 changes: 46 additions & 0 deletions lib/generated/l10n/zulip_localizations_fr.dart
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,33 @@ class ZulipLocalizationsFr extends ZulipLocalizations {
String get errorUnresolveTopicFailedTitle =>
'Failed to mark topic as unresolved';

@override
String get actionSheetOptionSeeWhoReacted => 'See who reacted';

@override
String get seeWhoReactedSheetNoReactions => 'This message has no reactions.';

@override
String seeWhoReactedSheetHeaderLabel(int num) {
return 'Emoji reactions ($num total)';
}

@override
String seeWhoReactedSheetEmojiNameWithVoteCount(String emojiName, int num) {
String _temp0 = intl.Intl.pluralLogic(
num,
locale: localeName,
other: '$num votes',
one: '1 vote',
);
return '$emojiName: $_temp0';
}

@override
String seeWhoReactedSheetUserListLabel(String emojiName, int num) {
return 'Votes for $emojiName ($num)';
}

@override
String get actionSheetOptionCopyMessageText => 'Copy message text';

Expand Down Expand Up @@ -796,6 +823,25 @@ class ZulipLocalizationsFr extends ZulipLocalizations {
@override
String get reactedEmojiSelfUser => 'You';

@override
String get reactionChipsLabel => 'Reactions';

@override
String reactionChipLabel(String emojiName, String votes) {
return '$emojiName: $votes';
}

@override
String reactionChipVotesYouAndOthers(int otherUsersCount) {
String _temp0 = intl.Intl.pluralLogic(
otherUsersCount,
locale: localeName,
other: 'You and $otherUsersCount others',
one: 'You and 1 other',
);
return '$_temp0';
}

@override
String onePersonTyping(String typist) {
return '$typist is typing…';
Expand Down
Loading
Loading