Conversation
📝 WalkthroughWalkthroughAdds three-tier "Dark Essence" data across feat tables, spell definitions, and localization: new feat rows, updated spell effect entries for DarkEssence1–3, and six new TLK strings. No deletions of existing entries; changes are additive/replacements within data files. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (2)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
swlor2_tga/ife_dkessence.tgais excluded by!**/*.tga
📒 Files selected for processing (5)
swlor2_2da/CLS_FEAT_FIGHT.2daswlor2_2da/feat.2daswlor2_2da/spells.2daswlor2_tlk/swlor2_tlk.tlkswlor2_tlk/swlor2_tlk.tlk.json
🔇 Additional comments (2)
swlor2_2da/feat.2da (1)
2001-2003: Manual verification required: The original review comment cannot be verified without access to the repository code. A developer with direct access to the codebase should verify:
- The feat entries at lines 2001-2003 exist and match the described structure
- The icon file
ife_dkessenceis present in the hak resources- All six TLK IDs (16872491-16872496) are properly defined in the TLK data
- The relationship between Dark Essence and Benevolence entries across feat.2da and spells.2da
swlor2_tlk/swlor2_tlk.tlk.json (1)
64992-65003: LGTM!The name entries for the three Dark Essence tiers are correctly structured with sequential IDs and consistent naming.
| 1214 DarkEssence1 1997 1 99 1 | ||
| 1214 DarkEssence2 1998 1 99 1 | ||
| 1214 DarkEssence3 1999 1 99 1 No newline at end of file |
There was a problem hiding this comment.
Duplicate row indices will break feat lookups.
All three new entries use row index 1214, which is already assigned to ZenMarksmanship on line 1218. In 2DA files, row indices must be unique—duplicate indices cause the game engine to only recognize one entry, leaving the others inaccessible.
🔎 Proposed fix: Use sequential row indices
-1214 DarkEssence1 1997 1 99 1
-1214 DarkEssence2 1998 1 99 1
-1214 DarkEssence3 1999 1 99 1
+1215 DarkEssence1 1997 1 99 1
+1216 DarkEssence2 1998 1 99 1
+1217 DarkEssence3 1999 1 99 1 📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| 1214 DarkEssence1 1997 1 99 1 | |
| 1214 DarkEssence2 1998 1 99 1 | |
| 1214 DarkEssence3 1999 1 99 1 | |
| 1215 DarkEssence1 1997 1 99 1 | |
| 1216 DarkEssence2 1998 1 99 1 | |
| 1217 DarkEssence3 1999 1 99 1 |
🤖 Prompt for AI Agents
In swlor2_2da/CLS_FEAT_FIGHT.2da around lines 1219 to 1221 the three new entries
all use the duplicate row index 1214 which conflicts with the existing
ZenMarksmanship entry and will break feat lookups; update each of the three
DarkEssence entries to use unique, sequential unused row indices (for example
1219, 1220, 1221 or the next available indices after 1218), ensuring no two rows
share the same index and preserving the original column values for each entry.
| { | ||
| "id": 95278, | ||
| "text": "Dark Essence I Description" | ||
| }, | ||
| { | ||
| "id": 95279, | ||
| "text": "Dark Essence II Description" | ||
| }, | ||
| { | ||
| "id": 95280, | ||
| "text": "Dark Essence III Description" | ||
| }, |
There was a problem hiding this comment.
Replace placeholder text with actual ability descriptions.
The description entries contain literal placeholder strings ("Dark Essence I Description", etc.) instead of actual descriptions of what each tier does. These user-facing strings should explain the game mechanics, effects, and requirements for each Dark Essence tier.
💡 Example structure based on similar game abilities
Consider replacing with descriptive text such as:
{
"id": 95278,
- "text": "Dark Essence I Description"
+ "text": "Channels dark side energy to enhance combat effectiveness. Grants +X to attack rolls and +Y damage for Z seconds."
},Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In swlor2_tlk/swlor2_tlk.tlk.json around lines 65004 to 65015 the entries use
placeholder strings like "Dark Essence I Description" rather than real
user-facing descriptions; replace each placeholder with a concise, player-facing
sentence or two that explains the ability’s mechanics, effects
(damage/heal/buff/debuff values or percent ranges), duration, cooldown,
range/targeting and any requirements or synergies; keep tone consistent with
existing abilities in the file, respect length limits for UI display, and ensure
grammar and punctuation are correct for localization pipelines.
1 participant
Necessary hak updates for new power "Dark Essence," a counterpart to Benevolence.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.