Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KMP: shared core + Compose UI, iOS app bootstrap, and persistence updates
Summary
This PR migrates the calculator core and UI to a shared KMP module, adds an iOS app wrapper using Compose Multiplatform, and updates Android wiring to consume the shared store. It also replaces the JVM-only engine with a KMP-safe parser, restores Android fonts via androidMain, and documents the iOS setup.
Key changes
Architecture (after)
graph TD subgraph Shared[KMP shared] UI[Compose UI] Store[CalculatorStore] Engine[CalculatorEngine] Repo[HistoryRepository] end subgraph Android[Android app] VM[CalculatorViewModel] DS[DataStoreHistoryRepository] end subgraph iOS[iOS app] Swift[SwiftUI Host] IOSRepo[IosHistoryRepository] end Swift --> UI VM --> Store Store --> Engine Store --> Repo DS --> Repo IOSRepo --> RepoData Flow
sequenceDiagram participant UI as Compose UI (shared) participant Store as CalculatorStore (shared) participant Engine as CalculatorEngine (shared) participant History as HistoryRepository (platform) UI->>Store: onAction(CalculatorAction) Store->>Engine: evaluate(...) / toggleLastOperandSign(...) Engine-->>Store: EvaluationResult / updated expression Store->>History: addHistory(...) Store-->>UI: uiState (StateFlow) Store-->>UI: invalidExpressionEvents (SharedFlow)iOS setup notes