Skip to content

fix(components/input-layout-date): min max should correction for manual input#1995

Open
ickisIckis wants to merge 3 commits intov4from
fix/input-day-min-max
Open

fix(components/input-layout-date): min max should correction for manual input#1995
ickisIckis wants to merge 3 commits intov4from
fix/input-day-min-max

Conversation

@ickisIckis
Copy link
Copy Markdown
Contributor

fix(components/input-layout-date): min max should correction for manual input

@ickisIckis ickisIckis added state:help_wanted Extra attention is needed version:4 labels Aug 20, 2024
@ickisIckis ickisIckis added this to the 4.4.0 milestone Aug 20, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 20, 2024

Visit the preview URL for this PR (updated for commit be44a70):

https://prizm-v4--pr1995-fix-input-day-min-ma-se5q7tep.web.app

(expires Mon, 26 Aug 2024 10:44:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7c62ed8dbabf5e2d6b2084ca9e107cc206d30dbd

@ZurabDev ZurabDev changed the base branch from main to v4 August 23, 2024 05:22
@ickisIckis ickisIckis assigned ickisIckis and ZurabDev and unassigned ickisIckis Sep 16, 2024
@ickisIckis ickisIckis added the state:in_progress We work on this issue label Sep 16, 2024
@ickisIckis
Copy link
Copy Markdown
Contributor Author

@ZurabDev, нужно доработать и сделать на v5


protected updateValue(value: T): void {
if (this.disabled || this.valueIdenticalComparator(this.value, value)) {
if (this.disabled /*|| this.valueIdenticalComparator(this.value, value)*/) {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

нужен ли этот код?

@alexhawkins94
Copy link
Copy Markdown

при частичном редактировании даты автоисправление происходит после потери фокуса на инпуте.
например:
-отредактировать одну цифру в годе, чтоб задать год за пределами диапазона

image

в inputDateTime поведение аналогичного функционала отличается - там происходит сразу автоисправление во время ввода при редактировании, не дожидаясь когда пользователь уберет фокус с инпута

@ZurabDev ZurabDev modified the milestones: 4.4.0, 4.5.1 Oct 3, 2024
@ickisIckis ickisIckis mentioned this pull request Oct 10, 2024
6 tasks
@alexhawkins94 alexhawkins94 removed this from the 4.5.1 milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:help_wanted Extra attention is needed state:in_progress We work on this issue state:reopen version:4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants