fix(components/multi-select): chevron overlaps input for layout with status #1744 v4#2373
Open
ickisIckis wants to merge 1 commit intov4from
Open
fix(components/multi-select): chevron overlaps input for layout with status #1744 v4#2373ickisIckis wants to merge 1 commit intov4from
ickisIckis wants to merge 1 commit intov4from
Conversation
|
Visit the preview URL for this PR (updated for commit 9161c98): https://prizm-v4--pr2373-fix-multiselect-mark-zfmy0ntu.web.app (expires Sat, 15 Mar 2025 14:44:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7c62ed8dbabf5e2d6b2084ca9e107cc206d30dbd |
bumalai
reviewed
Mar 10, 2025
| [active]="singleLine" | ||
| [class.hidden]="singleLine" | ||
| [reserveSpace]="{ x: 48 }" | ||
| [reserveSpace]="layoutComponent?.status === 'default' ? { x: 48 } : { x: 76 }" |
Contributor
There was a problem hiding this comment.
этот input звучит как хак, который не смогли через css выровнять
Contributor
Author
There was a problem hiding this comment.
ты имеешь ввиду инпут reserveSpace в принципе?
Contributor
Author
There was a problem hiding this comment.
можно завести задачу на рефактор для OverflowService, изучить варианты реализации с css
bumalai
approved these changes
Mar 12, 2025
ickisIckis
added
availability:reviewed
alexhawkins94
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(components/multi-select): chevron overlaps input for layout with status #1744
fix(components/tree-multi-select): chevron overlaps input for layout with status #1744