feat(components/none-content): add new component #2404#2442
Merged
ickisIckis merged 7 commits intomainfrom Apr 8, 2025
Merged
Conversation
ickisIckis
added
availability:review
and removed
state:in_progress
bumalai
reviewed
Apr 1, 2025
| @@ -0,0 +1,9 @@ | |||
| import { PrizmLanguageNoneContent } from '../../interfaces'; | |||
|
|
|||
| export const PRIZM_RUSSIAN_NONE_CONTENT: PrizmLanguageNoneContent = { | |||
Contributor
There was a problem hiding this comment.
а надо ли вообще давать дефолтные значения?
я думаю должен быть только кастом
Contributor
Author
There was a problem hiding this comment.
я исходила из требований к компоненту
https://prizmds.gitbook.io/documentation/patterns/none-content
а также обсудили с @PrizmDS
- заголовок есть всегда и его нельзя менять и удалять.
- текст во втором блоке рекомендован всегда, по необходимости его можно менять
Contributor
Author
There was a problem hiding this comment.
по согласованию с @PrizmDS тексты уберем - будут просто слоты. тесты из описаний являются рекомендацией для дизайнеров
сами тексты переходят в пример.
…texts, examples upadete #2404
There was a problem hiding this comment.
Copilot reviewed 15 out of 23 changed files in this pull request and generated no comments.
Files not reviewed (8)
- apps/doc/src/app/components/none-content/examples/base/none-content-base-example.component.html: Language not supported
- apps/doc/src/app/components/none-content/examples/custom/none-content-custom-example.component.html: Language not supported
- apps/doc/src/app/components/none-content/none-content-example.component.html: Language not supported
- apps/doc/src/app/components/none-content/none-content-example.component.less: Language not supported
- apps/doc/src/app/components/side-menu/examples/side-menu-example-basic/side-menu-example-basic.component.html: Language not supported
- apps/doc/src/app/components/side-menu/examples/side-menu-example-basic/side-menu-example-basic.component.less: Language not supported
- libs/components/src/lib/components/none-content/none-content.component.html: Language not supported
- libs/components/src/lib/components/none-content/none-content.component.less: Language not supported
There was a problem hiding this comment.
Copilot reviewed 13 out of 21 changed files in this pull request and generated no comments.
Files not reviewed (8)
- apps/doc/src/app/components/none-content/examples/base/none-content-base-example.component.html: Language not supported
- apps/doc/src/app/components/none-content/examples/custom/none-content-custom-example.component.html: Language not supported
- apps/doc/src/app/components/none-content/none-content-example.component.html: Language not supported
- apps/doc/src/app/components/none-content/none-content-example.component.less: Language not supported
- apps/doc/src/app/components/side-menu/examples/side-menu-example-basic/side-menu-example-basic.component.html: Language not supported
- apps/doc/src/app/components/side-menu/examples/side-menu-example-basic/side-menu-example-basic.component.less: Language not supported
- libs/components/src/lib/components/none-content/none-content.component.html: Language not supported
- libs/components/src/lib/components/none-content/none-content.component.less: Language not supported
bumalai
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(components/none-content): add new component #2404
feat(doc/side-menu): improve example in accordance with style guides #2418
resolved #2404
resolved #2418