Skip to content

fix: typing text is black on dark mode#100

Merged
zytact merged 1 commit intomainfrom
01-09-fix_typing_text_is_black_on_dark_mode
Jan 9, 2026
Merged

fix: typing text is black on dark mode#100
zytact merged 1 commit intomainfrom
01-09-fix_typing_text_is_black_on_dark_mode

Conversation

@zytact
Copy link
Copy Markdown
Owner

@zytact zytact commented Jan 9, 2026

Summary by CodeRabbit

  • Style

    • Enhanced dark mode support for text input styling with improved visual consistency across light and dark themes.
  • Tests

    • Updated test assertions to validate styling changes.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
strokeshare Ready Ready Preview, Comment Jan 9, 2026 3:43pm

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 9, 2026

Walkthrough

InfiniteCanvas textarea styling is refactored to move text color from inline styles to CSS classes, enabling responsive dark mode support (text-black dark:text-white). Tests are updated to verify class-based color assertions instead of inline styles.

Changes

Cohort / File(s) Change Summary
InfiniteCanvas styling migration
components/ui/InfiniteCanvas.tsx, components/ui/__tests/InfiniteCanvas.test.tsx
Removed inline style.color: currentColor from textarea and replaced with CSS classes for dark mode support. Test expectations updated from inline style checks to class-based assertions for light and dark theme validation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • zytact/strokeshare#65 — Modifies InfiniteCanvas text color handling and related component styling, complementing this PR's class-based approach.

Poem

A rabbit hops through styles so fine,
Moving color from inline to design,
Dark modes now dance in harmony's light,
From gray to black, from day into night! 🐰✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main fix: addressing dark mode text color visibility by updating text styling in InfiniteCanvas textarea component.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c49b977 and 5a7a15c.

📒 Files selected for processing (2)
  • components/ui/InfiniteCanvas.tsx
  • components/ui/__tests/InfiniteCanvas.test.tsx
🔇 Additional comments (2)
components/ui/InfiniteCanvas.tsx (1)

1891-1891: LGTM! Clean dark mode implementation.

The migration from inline style.color: currentColor to Tailwind's class-based approach (text-black dark:text-white) is the right solution for responsive dark mode support. This ensures text visibility in both light and dark themes while following Tailwind CSS best practices.

components/ui/__tests/InfiniteCanvas.test.tsx (1)

470-472: LGTM! Test correctly validates class-based styling.

The test assertions properly verify the presence of both text-black and dark:text-white classes, correctly reflecting the implementation change from inline styles to CSS classes. This ensures the dark mode fix is properly covered by tests.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Owner Author

zytact commented Jan 9, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@zytact zytact merged commit ddf91e9 into main Jan 9, 2026
4 checks passed
@zytact zytact deleted the 01-09-fix_typing_text_is_black_on_dark_mode branch January 9, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant