Checking the equality of dimensions with HashSet#8
Open
krishnanand5 wants to merge 1 commit intozzjas:masterfrom
Open
Checking the equality of dimensions with HashSet#8krishnanand5 wants to merge 1 commit intozzjas:masterfrom
krishnanand5 wants to merge 1 commit intozzjas:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I am proposing a fix for a couple of flaky tests found in
org.apache.druid.data.input.AvroStreamInputFormatTest.testParseSchemalessandorg.apache.druid.data.input.AvroStreamInputRowParserTest.testParseSchemaless.The mentioned tests compare if the retrieved schema is similar to the default schema that is individually stored in the test files. When the schema is being retrieved, the schema elements are not retrieved in order and hence that is causing the flakiness from time to time. The flakiness was captured by the NonDex tool.
https://github.com/krishnanand5/druid/blob/ad32f8458670339808a3136a9578a10a52b8394f/extensions-core/avro-extensions/src/test/java/org/apache/druid/data/input/AvroStreamInputRowParserTest.java#L304
In order to overcome this problem, I am proposing to use a HashSet to carry out the string equality check.
Steps to verify the patch:
https://github.com/apache/druid.git.mvn install -pl extensions-core/s3-extensions -am -DskipTests.mvn -pl extensions-core/s3-extensions test -Dtest=org.apache.druid.data.input.AvroStreamInputFormatTest#testParseSchemaless(or)
mvn -pl extensions-core/s3-extensions test -Dtest=org.apache.druid.data.input.AvroStreamInputRowParserTest#testParseSchemalessmvn -pl extensions-core/s3-extensions edu.illinois:nondex-maven-plugin:2.1.1:nondex -Dtest=org.apache.druid.data.input.AvroStreamInputFormatTest.testParseSchemaless(or)
mvn -pl extensions-core/s3-extensions edu.illinois:nondex-maven-plugin:2.1.1:nondex -Dtest=org.apache.druid.data.input.AvroStreamInputRowParserTest.testParseSchemalessmvn -pl extensions-core/s3-extensions edu.illinois:nondex-maven-plugin:2.1.1:nondex -DnondexRuns=100 -Dtest=org.apache.druid.data.input.AvroStreamInputFormatTest.testParseSchemaless(or)
mvn -pl extensions-core/s3-extensions edu.illinois:nondex-maven-plugin:2.1.1:nondex -DnondexRuns=100 -Dtest=org.apache.druid.data.input.AvroStreamInputRowParserTest.testParseSchemalessRelease note
Addressed a minor flakiness that was observed in
assertInputRowCorrect()This PR has: