Rebuild Zones with mismatched roofs#1013
Draft
RuffledPlume wants to merge 1 commit into117HD:masterfrom
Draft
Conversation
Contributor
RuffledPlume
commented
Mar 18, 2026
RuffledPlume
commented
- Moved Jobs into their own package
- Moved Roof Rebuild from a Generic Job into its own job
- RoofChangesJob
- Tracks mismatched roofs in a flat boolean array
- SceneManager when processing job result checks if a zone is matched & marks the zone for rebuild
* Moved Jobs into their own package * Moved Roof Rebuild from a Generic Job into its own job * RoofChangesJob * Tracks mismatched roofs in a flat boolean array * SceneManager when processing job result checks if a zone is matched & marks the zone for rebuild
RuffledPlume
force-pushed
the
RoofChanges
branch
from
c0c8be3 to
e29b0e6
Compare
Member
|
Since the Chambers of Xeric issue somehow wasn't fixed by this, I think it's best if we leave this open till we can figure that one out. There isn't really a rush though, as the issue is probably rare, and c7b4282 works around the issue for Chambers of Xeric specifically. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.