ConcurrentPool should process clientCallbacks if waiting on the client#1015
Draft
RuffledPlume wants to merge 3 commits into117HD:masterfrom
Draft
ConcurrentPool should process clientCallbacks if waiting on the client#1015RuffledPlume wants to merge 3 commits into117HD:masterfrom
RuffledPlume wants to merge 3 commits into117HD:masterfrom
Conversation
aHooder
reviewed
Mar 21, 2026
Member
aHooder
left a comment
aHooder
left a comment
There was a problem hiding this comment.
This might make sense to do anyway at some point, if we start intentionally blocking on the client thread, but I'll hold off on it for now since it effectively does nothing currently.
| while ((obj = pool.poll()) == null) { | ||
| if (!parkedThreads.contains(currentThread)) | ||
| parkedThreads.add(currentThread); | ||
| JobSystem.processPendingClientCallbacks(); |
Member
There was a problem hiding this comment.
While proof reading this, I realised that this call actually never does anything (currently). processPendingClientCallbacks exits early if it's not on the client thread, and acquireBlocking is currently only ever called from render threads in drawDynamic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ontop of
Acquirehaving a timeout, we not process clientCallbacks if the client is the thread currently being blocked, this is to avoid waiting when we can easily unblock the workers