Skip to content

Fixes for textures only ground blending mode#970

Open
Jin-Jiyunsun wants to merge 13 commits into117HD:masterfrom
Jin-Jiyunsun:texture-only-fixes
Open

Fixes for textures only ground blending mode#970
Jin-Jiyunsun wants to merge 13 commits into117HD:masterfrom
Jin-Jiyunsun:texture-only-fixes

Conversation

@Jin-Jiyunsun
Copy link
Contributor

Pairs with #969

Winter not fixed yet seems like there's still some colour blending going on somehow

@Jin-Jiyunsun
Copy link
Contributor Author

Jin-Jiyunsun commented Feb 28, 2026

java_uFC8WuB2EV java_AJkdJYwii0

issue with winter theme, can be fixed by setting the paths to blended: false but it shouldnt be be blending whatever colour this is right?

@aHooder
Copy link
Member

aHooder commented Mar 22, 2026

Hmm, this issue is apparently caused by the material brightness set here, which bleeds into the snow because texture blending is effectively material blending:

  {
    "name": "WINTER_JAGGED_STONE_TILE_LIGHT",
    "parent": "WINTER_JAGGED_STONE_TILE",
    "brightness": 1.825
  },

Arguably it is correct behaviour, and I don't think it can be fixed in code without some crazy hacks, so our best option I think is to fix this by making these tile overrides shift the brightness instead of having the material do it.

@Jin-Jiyunsun
Copy link
Contributor Author

Hmm, this issue is apparently caused by the material brightness set here, which bleeds into the snow because texture blending is effectively material blending:

  {
    "name": "WINTER_JAGGED_STONE_TILE_LIGHT",
    "parent": "WINTER_JAGGED_STONE_TILE",
    "brightness": 1.825
  },

Arguably it is correct behaviour, and I don't think it can be fixed in code without some crazy hacks, so our best option I think is to fix this by making these tile overrides shift the brightness instead of having the material do it.

This should be fixed now but I cant confirm if it interferes with the original blending mode until the bug which makes blendingTextures effect both ON and TEXTURES, when it should only effect TEXTURES

@Jin-Jiyunsun
Copy link
Contributor Author

Jin-Jiyunsun commented Mar 22, 2026

Heres what it looks like without the extra path I add in:
image
Heres what it looks like after:
image
And here are the tiles I think are blending still when they shouldn't be, all the tile_overrides involved have blending: false
image

I don't think this is an issue specific to the new blending mode, but rather something thats only been noticed now
Either the whole tile is somehow blending with the tiles around it, or the parts in red, idk?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants