Bias GroundItems to ensure they sit above surfaces#988
Open
RuffledPlume wants to merge 8 commits into117HD:masterfrom
Open
Bias GroundItems to ensure they sit above surfaces#988RuffledPlume wants to merge 8 commits into117HD:masterfrom
RuffledPlume wants to merge 8 commits into117HD:masterfrom
Conversation
Contributor
RuffledPlume
commented
Mar 5, 2026
f11d745 to
b4ab7c3
Compare
Member
Member
|
The code LGTM, but how was the bias of 125 chosen? |
Contributor
Author
Most tiles and models have a bias of 1 to 12, that's because they are fixing coplanar triangles, however since this is a problem of items intersecting fully with the terrain and models, it's not a coplanar issue. So I found 125 is around about the amount needed to resolve most issues |
Contributor
Author
|
This might no longer be needed, Adam fixes a RL bug which improves the cases shown in the OP. |
Contributor
|
Imo it's worth it |
Contributor
Author
|
I guess we could detect if the dropped item is on a tile with objects, since that should be the remaining case where it happens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

