Improve Scene Loading when client is close to running out of memory#993
Open
RuffledPlume wants to merge 1 commit into117HD:masterfrom
Open
Improve Scene Loading when client is close to running out of memory#993RuffledPlume wants to merge 1 commit into117HD:masterfrom
RuffledPlume wants to merge 1 commit into117HD:masterfrom
Conversation
RuffledPlume
force-pushed
the
ReuseSceneContextData
branch
6 times, most recently
from
fe07192 to
e0c8b0d
Compare
RuffledPlume
changed the title
Contributor
Author
|
PR has been improved, ontop of reusing the SceneContext to avoid allocating 16 MBs during scene Load. It now tracks the memory state over the last 64 frames to determine if we're consistently running close to the max memory, if we're in this state then scene loading is forced to be sync load instead of going wide across job system workers. |
RuffledPlume
force-pushed
the
ReuseSceneContextData
branch
11 times, most recently
from
3432e03 to
86fa93e
Compare
* Reuse Previous SceneContext Data * Added GC Hint to try to catch when a OOM is impending * Moved Model Pushing Arrays into LegacySceneContext Class * Print Memory stats before & after hinting GC * Track Memory State across the last 64 frames * This allows us to determine if we're consistently running close to the edge of the max memory * Override Expanded Chunk Loading if we're running low on memory, effectively forcing lowMemory mode
RuffledPlume
force-pushed
the
ReuseSceneContextData
branch
from
86fa93e to
b85e1c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Time bounded GC added before loading next scene: