Skip to content

Comments

Update CI/CD workflows for improved build and test processes#13

Merged
JIngeholm merged 1 commit intomainfrom
fixing_tests_2
Feb 22, 2026
Merged

Update CI/CD workflows for improved build and test processes#13
JIngeholm merged 1 commit intomainfrom
fixing_tests_2

Conversation

@JIngeholm
Copy link
Collaborator

Co-authored-by: GPT-5.1

Copilot AI review requested due to automatic review settings February 22, 2026 19:14
@JIngeholm JIngeholm merged commit f69b39c into main Feb 22, 2026
3 checks passed
@JIngeholm JIngeholm deleted the fixing_tests_2 branch February 22, 2026 19:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates CI/CD workflows by reorganizing when workflows run and which tests are executed. The changes remove Playwright UI tests from the continuous deployment workflow and focus the build_and_test workflow on infrastructure tests only, while adding a pull request trigger to the deployment workflow.

Changes:

  • Added pull_request trigger to continuous deployment workflow
  • Removed Playwright installation and test execution from continuous deployment workflow
  • Updated build_and_test workflow to specify Release configuration and run only infrastructure tests
  • Fixed indentation in build_and_test workflow

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/continous-deployment.yml Adds pull_request trigger and removes Playwright test steps from deployment workflow
.github/workflows/build_and_test.yml Updates to use Release configuration and clarifies that only infrastructure tests are run
Comments suppressed due to low confidence (1)

.github/workflows/continous-deployment.yml:33

  • The build step in the continuous deployment workflow does not specify a Release configuration (-c Release), while the build_and_test.yml workflow does. This inconsistency means different build configurations are used in different workflows, which could lead to environment-specific issues not being caught. Consider adding -c Release here for consistency.
        run: dotnet build --no-restore

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -29,17 +32,6 @@ jobs:
- name: Build project
run: dotnet build --no-restore

Copy link

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Playwright tests (test/Chirp.Web.Playwright.Test) have been removed from this workflow and are not present in any other workflow file. This means UI/end-to-end tests are no longer being executed in CI/CD. Consider either keeping these tests in at least one workflow (such as build_and_test.yml) or creating a separate workflow for them to ensure adequate test coverage.

Suggested change
- name: Run Playwright tests
run: dotnet test test/Chirp.Web.Playwright.Test/Chirp.Web.Playwright.Test.csproj --no-build

Copilot uses AI. Check for mistakes.
Comment on lines +10 to +12
pull_request:
branches:
- main
Copy link

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull_request trigger is incorrectly placed inside the push trigger block. This will cause a YAML syntax error. The pull_request trigger should be at the same indentation level as the push trigger, not nested within it.

Suggested change
pull_request:
branches:
- main
pull_request:
branches:
- main

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant