Update CI/CD workflows for improved build and test processes#13
Update CI/CD workflows for improved build and test processes#13
Conversation
Co-authored-by: GPT-5.1
There was a problem hiding this comment.
Pull request overview
This PR updates CI/CD workflows by reorganizing when workflows run and which tests are executed. The changes remove Playwright UI tests from the continuous deployment workflow and focus the build_and_test workflow on infrastructure tests only, while adding a pull request trigger to the deployment workflow.
Changes:
- Added pull_request trigger to continuous deployment workflow
- Removed Playwright installation and test execution from continuous deployment workflow
- Updated build_and_test workflow to specify Release configuration and run only infrastructure tests
- Fixed indentation in build_and_test workflow
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/continous-deployment.yml | Adds pull_request trigger and removes Playwright test steps from deployment workflow |
| .github/workflows/build_and_test.yml | Updates to use Release configuration and clarifies that only infrastructure tests are run |
Comments suppressed due to low confidence (1)
.github/workflows/continous-deployment.yml:33
- The build step in the continuous deployment workflow does not specify a Release configuration (-c Release), while the build_and_test.yml workflow does. This inconsistency means different build configurations are used in different workflows, which could lead to environment-specific issues not being caught. Consider adding -c Release here for consistency.
run: dotnet build --no-restore
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -29,17 +32,6 @@ jobs: | |||
| - name: Build project | |||
| run: dotnet build --no-restore | |||
|
|
|||
There was a problem hiding this comment.
The Playwright tests (test/Chirp.Web.Playwright.Test) have been removed from this workflow and are not present in any other workflow file. This means UI/end-to-end tests are no longer being executed in CI/CD. Consider either keeping these tests in at least one workflow (such as build_and_test.yml) or creating a separate workflow for them to ensure adequate test coverage.
| - name: Run Playwright tests | |
| run: dotnet test test/Chirp.Web.Playwright.Test/Chirp.Web.Playwright.Test.csproj --no-build |
| pull_request: | ||
| branches: | ||
| - main |
There was a problem hiding this comment.
The pull_request trigger is incorrectly placed inside the push trigger block. This will cause a YAML syntax error. The pull_request trigger should be at the same indentation level as the push trigger, not nested within it.
| pull_request: | |
| branches: | |
| - main | |
| pull_request: | |
| branches: | |
| - main |
Co-authored-by: GPT-5.1