Skip to content

Update CI/CD workflows for improved build and test processes #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JIngeholm merged 1 commit into from
Feb 22, 2026
Merged

Update CI/CD workflows for improved build and test processes #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions .github/workflows/build_and_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
name: .NET Build and Test (CI)
name: .NET Build and Test

permissions:
contents: write
pull-requests: write

on:
push:
branches:
- main
tags:
- "v*.*.*"
pull_request:
branches:
- main
push:
branches:
- main
tags:
- "v*.*.*"
pull_request:
branches:
- main

jobs:
build:
Expand All @@ -29,10 +29,10 @@ jobs:
run: dotnet restore

- name: Build project
run: dotnet build --no-restore
run: dotnet build --no-restore -c Release

- name: Tests
- name: Tests (infrastructure only)
run: |
export Authentication_Github_ClientId="${{ secrets.GITHUBCLIENTID }}"
export Authentication_Github_ClientSecret="${{ secrets.GITHUBCLIENTSECRET }}"
dotnet test test/Chirp.Infrastructure.Test/Chirp.Infrastructure.Test.csproj --no-build --verbosity normal
dotnet test test/Chirp.Infrastructure.Test/Chirp.Infrastructure.Test.csproj --no-build -c Release --verbosity normal
14 changes: 3 additions & 11 deletions .github/workflows/continous-deployment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ on:
branches:
- main
- master
pull_request:
branches:
- main
Comment on lines +10 to +12
Copy link

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull_request trigger is incorrectly placed inside the push trigger block. This will cause a YAML syntax error. The pull_request trigger should be at the same indentation level as the push trigger, not nested within it.

Suggested change
pull_request:
branches:
- main
pull_request:
branches:
- main

Copilot uses AI. Check for mistakes.
# allow manual triggers for now too
workflow_dispatch:

Expand All @@ -29,17 +32,6 @@ jobs:
- name: Build project
run: dotnet build --no-restore

Copy link

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Playwright tests (test/Chirp.Web.Playwright.Test) have been removed from this workflow and are not present in any other workflow file. This means UI/end-to-end tests are no longer being executed in CI/CD. Consider either keeping these tests in at least one workflow (such as build_and_test.yml) or creating a separate workflow for them to ensure adequate test coverage.

Suggested change
- name: Run Playwright tests
run: dotnet test test/Chirp.Web.Playwright.Test/Chirp.Web.Playwright.Test.csproj --no-build

Copilot uses AI. Check for mistakes.
- name: Install Playwright
run: |
dotnet tool install --global Microsoft.Playwright.CLI || true
playwright install --with-deps

- name: Tests
run: |
export Authentication_Github_ClientId="${{ secrets.GITHUBCLIENTID }}"
export Authentication_Github_ClientSecret="${{ secrets.GITHUBCLIENTSECRET }}"
dotnet test --no-build -c Release --verbosity normal

deploy:
needs: build
runs-on: ubuntu-latest
Expand Down
Loading