Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces a new barycentric data generation feature along with appropriate testing support. Key changes include:
- Implementation of the new script (misc/generate.py) for generating test data using barycentric formula interpolation.
- Integration of the new barycentric data generation into the testing framework via verify_data.py.
- Addition of the corresponding output file (misc/barycentric.toml) containing the generated test cases.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| misc/generate.py | New script implementing barycentric interpolation data generation. |
| verify_data.py | Updated to verify barycentric test data. |
| misc/barycentric.toml | Contains barycentric interpolation test cases generated by the script. |
pasabanov
force-pushed
the
misc
branch
2 times, most recently
from
14d7f6e to
28d77b8
Compare
1. Implemented `misc/generate.py` script to generate test data for barycentric formula interpolation. `mp.dps = 30` was chosen as the smallest multiple of 10 that gives the most accurate results after rounding to `precision = 17`. 2. Created `misc/barycentric.toml` as the output of the script. 3. Updated `verify_data.py` to verify the generated data against the saved data.
This was referenced Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Related: #1 #9
Description
misc/generate.pyscript to generate test data for barycentric formula interpolation.mp.dps = 30was chosen as the smallest multiple of 10 that gives the most accurate results after rounding toprecision = 17.misc/barycentric.tomlas the output of the script.verify_data.pyto verify the generated data against the saved data.