Skip to content

fix: added target and rel to social icons in hero-section and footer; wherever it was missing#703

Open
reach2saksham wants to merge 1 commit intoAOSSIE-Org:mainfrom
reach2saksham:fix/social-redirections
Open

fix: added target and rel to social icons in hero-section and footer; wherever it was missing#703
reach2saksham wants to merge 1 commit intoAOSSIE-Org:mainfrom
reach2saksham:fix/social-redirections

Conversation

@reach2saksham
Copy link
Contributor

@reach2saksham reach2saksham commented Mar 24, 2026

Addressed Issues:

Fixes #702

Added and ensured proper redirection by adding target="_blank" rel="noopener noreferrer" to all the social icons in hero section and footer, from whichever icon it was missing.

Screenshots/Recordings:

TODO: If applicable, add screenshots or recordings that demonstrate the interface before and after the changes.
NA

Additional Notes:

AI Usage Disclosure:

We encourage contributors to use AI tools responsibly when creating Pull Requests. While AI can be a valuable aid, it is essential to ensure that your contributions meet the task requirements, build successfully, include relevant tests, and pass all linters. Submissions that do not meet these standards may be closed without warning to maintain the quality and integrity of the project. Please take the time to understand the changes you are proposing and their impact. AI slop is strongly discouraged and may lead to banning and blocking. Do not spam our repos with AI slop.

Check one of the checkboxes below:

  • This PR does not contain AI-generated code at all.
  • This PR contains AI-generated code. I have read the AI Usage Policy and this PR complies with this policy. I have tested the code locally and I am responsible for it.

I have used the following AI models and tools: TODO

Checklist

  • My PR addresses a single issue, fixes a single bug or makes a single improvement.
  • My code follows the project's code style and conventions
  • If applicable, I have made corresponding changes or additions to the documentation
  • If applicable, I have made corresponding changes or additions to tests
  • My changes generate no new warnings or errors
  • I have joined the Discord server and I will share a link to this PR with the project maintainers there
  • I have read the Contribution Guidelines
  • Once I submit my PR, CodeRabbit AI will automatically review it and I will address CodeRabbit's comments.
  • I have filled this PR template completely and carefully, and I understand that my PR may be closed without review otherwise.

@coderabbitai
Copy link

coderabbitai bot commented Mar 24, 2026

Caution

Review failed

Failed to post review comments

📝 Walkthrough

Walkthrough

This PR adds security attributes to external links across two components. Specifically, it adds rel="noopener noreferrer" to social and external links in the page hero section, and adds both target="_blank" and rel="noopener noreferrer" to the footer's mail link.

Changes

Cohort / File(s) Summary
Social & External Links
src/app/page.jsx
Added rel="noopener noreferrer" to six Link components (Mail, GitHub, Discord, LinkedIn, X, YouTube) that open external destinations in new tabs.
Footer Mail Link
src/components/shared/Footer.jsx
Added target="_blank" and rel="noopener noreferrer" to the mailto link for consistent security attribute handling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • Zahnentferner

Poem

🐰 A rabbit hops through links so fine,
Adding shields to each external line,
"Noopener, noreferrer!" we cheer with glee,
Security practices, safe as can be! 🔒

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding target and rel attributes to social icons in the hero section and footer where they were missing.
Linked Issues check ✅ Passed The PR successfully addresses all coding requirements from issue #702: added rel="noopener noreferrer" to all social icons in the hero section and added both target="_blank" and rel="noopener noreferrer" to the YouTube and mail icons.
Out of Scope Changes check ✅ Passed All changes are directly related to the linked issue #702. The modifications only affect social icon links in the hero section and footer, with no unrelated alterations.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rel="noopener noreferrer" is missing from social icons and YouTube icon doesn't even have target="_blank"

1 participant