Skip to content

fix: added target and rel to social icons in hero-section and footer; wherever it was missing #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reach2saksham wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

fix: added target and rel to social icons in hero-section and footer; wherever it was missing #703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/app/page.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ export default function Home() {
>
<Link
target="_blank"
rel="noopener noreferrer"
aria-label="Contact by Mail"
className="text-zinc-500 transition hover:text-[#00843D] dark:text-zinc-400 dark:hover:text-yellow-400"
href="mailto:aossie.oss@gmail.com"
Expand All @@ -98,6 +99,7 @@ export default function Home() {
</Link>
<Link
target="_blank"
rel="noopener noreferrer"
aria-label="Follow on GitHub"
className="text-zinc-500 transition hover:text-[#00843D] dark:text-zinc-400 dark:hover:text-yellow-400"
href="https://github.com/AOSSIE-Org"
Expand All @@ -106,6 +108,7 @@ export default function Home() {
</Link>
<Link
target="_blank"
rel="noopener noreferrer"
aria-label="Join on Discord"
className="text-zinc-500 transition hover:text-[#00843D] dark:text-zinc-400 dark:hover:text-yellow-400"
href="https://discord.gg/hjUhu33uAn"
Expand All @@ -114,6 +117,7 @@ export default function Home() {
</Link>
<Link
target="_blank"
rel="noopener noreferrer"
aria-label="Follow on LinkedIn"
className="text-zinc-500 transition hover:text-[#00843D] dark:text-zinc-400 dark:hover:text-yellow-400"
href="https://www.linkedin.com/company/aossie/"
Expand All @@ -122,13 +126,16 @@ export default function Home() {
</Link>
<Link
target="_blank"
rel="noopener noreferrer"
aria-label="Follow on X (Twitter)"
className="text-zinc-500 transition hover:text-[#00843D] dark:text-zinc-400 dark:hover:text-yellow-400"
href="https://x.com/aossie_org"
>
<FontAwesomeIcon icon={faXTwitter} size="2xl" />
</Link>
<Link
target="_blank"
rel="noopener noreferrer"
aria-label="Subscribe on YouTube"
className="text-zinc-500 transition hover:text-[#00843D] dark:text-zinc-400 dark:hover:text-yellow-400"
href="https://www.youtube.com/@AOSSIE-Org"
Expand Down
2 changes: 1 addition & 1 deletion src/components/shared/Footer.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export function Footer() {
<div>
<h3 className="font-mono text-sm font-semibold text-zinc-900 dark:text-zinc-100 tracking-wider uppercase mb-4">Connect</h3>
<div className="flex flex-wrap gap-6">
<Link aria-label="Contact by Mail" className='text-zinc-500 hover:text-[#00843D] dark:text-zinc-400 dark:hover:text-yellow-400 transition' href='mailto:aossie.oss@gmail.com'>
<Link aria-label="Contact by Mail" className='text-zinc-500 hover:text-[#00843D] dark:text-zinc-400 dark:hover:text-yellow-400 transition' href='mailto:aossie.oss@gmail.com' target="_blank" rel="noopener noreferrer">
<FontAwesomeIcon icon={faEnvelope} size='xl' />
</Link>
<Link aria-label="Follow on GitHub" className='text-zinc-500 hover:text-[#00843D] dark:text-zinc-400 dark:hover:text-yellow-400 transition' href='https://github.com/AOSSIE-Org' target="_blank" rel="noopener noreferrer">
Expand Down