AGM-2840 added an article about selective mode filtering issues#326
Open
anastasiia-fedotova wants to merge 2 commits intomasterfrom
Open
Conversation
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Other comments (1)
-
docs/general/selective-mode-filtering-issues.md (33-34)
Same numbering issue in the Recommended solution section.
1. Using a mode where AdGuard VPN is active for all applications. In this mode, all traffic is routed through the VPN tunnel. 2. Avoiding Selective mode for messengers with dynamic network architectures
💡 To request another review, post a new comment with "/windsurf-review".
Comment on lines
33
to
34
| 1. Using a mode where AdGuard VPN is active for all applications. In this mode, all traffic is routed through the VPN tunnel. | ||
| 1. Avoiding Selective mode for messengers with dynamic network architectures No newline at end of file |
Contributor
There was a problem hiding this comment.
The file is missing a newline at the end. It's a good practice to end text files with a newline character.
Suggested change
| 1. Using a mode where AdGuard VPN is active for all applications. In this mode, all traffic is routed through the VPN tunnel. | |
| 1. Avoiding Selective mode for messengers with dynamic network architectures | |
| 1. Using a mode where AdGuard VPN is active for all applications. In this mode, all traffic is routed through the VPN tunnel. | |
| 2. Avoiding Selective mode for messengers with dynamic network architectures |
Comment on lines
+14
to
+16
| 1. Uses dynamic IP addresses | ||
| 1. Operates through large CDN and Meta infrastructure | ||
| 1. Does not provide public, up-to-date lists of IP addresses used by the application |
Contributor
There was a problem hiding this comment.
The ordered lists in this document use '1.' for each item instead of sequential numbering (1, 2, 3). While Markdown will render this correctly, using sequential numbers (1., 2., 3.) in the source improves readability when editing the file.
Suggested change
| 1. Uses dynamic IP addresses | |
| 1. Operates through large CDN and Meta infrastructure | |
| 1. Does not provide public, up-to-date lists of IP addresses used by the application | |
| 1. Uses dynamic IP addresses | |
| 2. Operates through large CDN and Meta infrastructure | |
| 3. Does not provide public, up-to-date lists of IP addresses used by the application |
Comment on lines
+24
to
+25
| 1. The app uses multiple domains and IP addresses for chats, media, and voice connections | ||
| 1. Some connections may be established directly without a clear association with the app |
Contributor
There was a problem hiding this comment.
Same numbering issue in the Discord section.
Suggested change
| 1. The app uses multiple domains and IP addresses for chats, media, and voice connections | |
| 1. Some connections may be established directly without a clear association with the app | |
| 1. The app uses multiple domains and IP addresses for chats, media, and voice connections | |
| 2. Some connections may be established directly without a clear association with the app |
|
Preview was deployed to: https://pull-request-326.kb-vpn.pages.dev/ |
1 similar comment
|
Preview was deployed to: https://pull-request-326.kb-vpn.pages.dev/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.