Skip to content

Conversation

@xsalonx
Copy link
Collaborator

@xsalonx xsalonx commented Dec 3, 2024

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • NA

Notable changes for developers:

  • Implement stored SQL views for selecting GAQ periods
  • Rework calculation of GAQ summary, change resultant data type on repositories level providing more detailed information, this is follow-up of [O2B-1435]
  • Add new typedefs and correct existing ones for QC/GAQ summaries related datatypes
  • Skip tests failing due to QC flags service logic changed in [O2B-1446] Allow flags creation to continue if initial one fails for sync #1902

Changes made to the database:

  • Add view for GAQ periods
  • Add SQL functions for calculation of aggregated quality

@codecov
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 92.15686% with 4 lines in your changes missing coverage. Please review.

Project coverage is 45.75%. Comparing base (cdd5656) to head (7f51328).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...e/migrations/v1/20250518123000-create-gaq-views.js 78.94% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1808      +/-   ##
==========================================
+ Coverage   45.56%   45.75%   +0.19%     
==========================================
  Files        1007     1009       +2     
  Lines       16653    16660       +7     
  Branches     2983     2981       -2     
==========================================
+ Hits         7588     7623      +35     
+ Misses       9065     9037      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xsalonx xsalonx changed the title [O2B-1365] Implement GAQ periods and summeries views [O2B-1365] Implement GAQ periods views Dec 3, 2024
@xsalonx xsalonx requested a review from martinboulais December 4, 2024 11:36
@xsalonx xsalonx marked this pull request as ready for review May 20, 2025 15:57
@xsalonx xsalonx requested a review from graduta May 29, 2025 09:16
@xsalonx xsalonx dismissed martinboulais’s stale review July 17, 2025 13:44

already approved

@xsalonx xsalonx merged commit b3a0d86 into main Jul 17, 2025
70 of 75 checks passed
@xsalonx xsalonx deleted the xsalonx/gaq/O2B-1365/just-gaq-views branch July 17, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants