This repository was archived by the owner on Feb 20, 2025. It is now read-only.
support custom filebeat config#244
Merged
chenquanzhao merged 1 commit intoAliyunContainerService:masterfrom Dec 11, 2019
Merged
support custom filebeat config#244chenquanzhao merged 1 commit intoAliyunContainerService:masterfrom
chenquanzhao merged 1 commit intoAliyunContainerService:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #244 +/- ##
==========================================
- Coverage 21.79% 21.46% -0.33%
==========================================
Files 7 7
Lines 748 778 +30
==========================================
+ Hits 163 167 +4
- Misses 557 581 +24
- Partials 28 30 +2
Continue to review full report at Codecov.
|
|
Ping @jzwlqx @chenquanzhao , Shall we take a review about this PR? I also need this feature. |
| root := newLogInfoNode("") | ||
| for _, k := range labelNames { | ||
| for _, prefix := range p.logPrefix { | ||
| customConfig := fmt.Sprintf(ENV_SERVICE_LOGS_CUSTOME_CONFIG_TEMPL, prefix) |
There was a problem hiding this comment.
这个地方 去遍历 labelNames。 你这边来匹配ENV_SERVICE_LOGS_CUSTOME_CONFIG_TEMPL。 是不是手误? @zlseu-edu #332
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
support custom all filebeat config.
ENV aliyun_logs_custom_config mount the user defined configs in configmap.