Draft
Conversation
AndreMiras
added a commit
that referenced
this pull request
Apr 18, 2022
We're only constructing the object for now
AndreMiras
added a commit
that referenced
this pull request
Apr 18, 2022
We're only constructing the object for now
AndreMiras
added a commit
that referenced
this pull request
Apr 18, 2022
AndreMiras
added a commit
that referenced
this pull request
Apr 18, 2022
AndreMiras
added a commit
that referenced
this pull request
Apr 18, 2022
AndreMiras
added a commit
that referenced
this pull request
Apr 18, 2022
AndreMiras
added a commit
that referenced
this pull request
Apr 18, 2022
AndreMiras
added a commit
that referenced
this pull request
Apr 18, 2022
AndreMiras
added a commit
that referenced
this pull request
Apr 18, 2022
AndreMiras
added a commit
that referenced
this pull request
Apr 18, 2022
AndreMiras
added a commit
that referenced
this pull request
Apr 18, 2022
AndreMiras
added a commit
that referenced
this pull request
Apr 18, 2022
Owner
|
FYI I've added a few dumb (and maybe flaky) tests in tests/test_magic.py for a start |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@AndreMiras not yet ready 😁
just starting the discussion ...
I have thought about how to add unit testing:
that was working for me, but of course its nowhere an automatic solution. (Also it doesnt test MagicApp)
taskkill /F /IM vlc.exeto just kill all open vlc windows. VLC has the characteristic, that every new app window will create a new WAS (session). That way we could easily stress test pycaw (Opening a lot of windows and closing them all instantly).Im proposing to use vlc since i cant find any other nice crossplattform solution (win 7 - 10)
What wont work:
Internet Explorer:
start iexplore music.mp3or any other file format will download the file<audio autoplay="autoplay"><source src="music.mp3" /></audio>a simple website wont work either: ProblemWindows Media Player:
What could work:
taskkill /F /IM powershell.exewhat could also interfere with the unit testing)