Web: Fix CAN options visibility for non-CAN boards by garvit000 · Pull Request #209 · ArduPilot/CustomBuild

garvit000 · 2026-01-17T18:11:24Z

This PR fixes Issue #151 where the "CAN" feature category remained visible even when selecting a board that does not support CAN.

The Fix:

Updated fillBuildOptions in JS to re-render the category list whenever the board selection changes.
Added logic to hide the "CAN" category if the selected board's metadata indicates has_can: false.
Updated backend metadata fetching to correctly identify CAN support for newer boards (e.g., CubeOrange) by following include directives in hwdef.dat.

Test Plan:

Select "CubeOrange" -> Verify "CAN" category is visible (True Positive).
Select "KakuteF4-Mini" -> Verify "CAN" category disappears (True Negative).

Closes #151

shiv-tyagi · 2026-01-18T16:17:10Z

metadata_manager/ap_src_meta_fetcher.py

                f"Redis connection established with {redis_host}:{redis_port}"
            )
-            self.__boards_key_prefix = "boards-"
+            # bump version to invalidate stale board metadata in cache


Please remove this change. We can handle the upgrade by manually clearing the cache.

Reverted the change

shiv-tyagi · 2026-01-18T16:22:00Z

metadata_manager/ap_src_meta_fetcher.py

Needs to be documented in the comment.

Updated the comment

shiv-tyagi · 2026-01-18T16:23:38Z

metadata_manager/ap_src_meta_fetcher.py

Let's remove this as well. No need to worry about the upgrade due to cached stuff. We can clear it manually.

shiv-tyagi · 2026-01-18T16:24:27Z

web/app.py

Better define a class for board with id, name and attributes, in the attributed put the has_can thing.

Defined a BoardMetadata class for above listed

garvit000 · 2026-01-18T18:46:45Z

Hey @shiv-tyagi thanks for reviewing, I have addressed all the requested changes could you re-review it.

shiv-tyagi · 2026-01-19T11:54:55Z

metadata_manager/ap_src_meta_fetcher.py

Let us just call it board.

shiv-tyagi · 2026-01-19T11:55:54Z

metadata_manager/ap_src_meta_fetcher.py

Suggested change

self.attributes = attributes

self.attributes = dict(attributes)

Let us make sure the board is not affected even it the passed attributes get mutated externally.

shiv-tyagi · 2026-01-19T11:58:37Z

metadata_manager/ap_src_meta_fetcher.py

Either keep the has_can thing at top level or inside attributes property. Not both.

shiv-tyagi · 2026-01-19T12:00:29Z

metadata_manager/ap_src_meta_fetcher.py

I don't think there is anything like "(legacy)" in our case which we need to handle..

shiv-tyagi · 2026-01-19T12:03:45Z

metadata_manager/ap_src_meta_fetcher.py

The repo needs to stay locked till you are done doing everything.

shiv-tyagi · 2026-01-19T12:06:27Z

metadata_manager/ap_src_meta_fetcher.py

Instead of these dictionaries. We should just return a list of Board objects. We would also need to handle the caching of those.

shiv-tyagi · 2026-01-19T12:07:14Z

metadata_manager/ap_src_meta_fetcher.py

Suggested change

list: A list of board metadata dictionaries, each containing

the board name and whether it supports CAN (has_can).

list: A list of Boards.

shiv-tyagi · 2026-01-19T12:10:22Z

web/static/js/add_build.js

Instead of hiding stuff at the frontend, we should make sure they don't even get returned from the backend. The filtering logic has to go in the backend.

Also, when we make some features disappear the features which are dependent on those should also disappear.

shiv-tyagi · 2026-01-19T12:11:29Z

metadata_manager/ap_src_meta_fetcher.py

Please follow the pattern in the codebase. Define a separate method in this class to do this parsing. You can prefix the method names with underscores to avoid potential external usage.

…rver

…EN for web service

There is no advantage of an extra route to open the same page. The query parameter on main route should do.

…ild page

garvit000 · 2026-02-12T00:05:47Z

Closing this in favor of #227 . The new PR has a cleaner commit history and addresses all review feedback in a single refactored commit.

Web: Fix CAN category visibility and update backend board metadata

76c69d8

shiv-tyagi requested changes Jan 18, 2026

View reviewed changes

Use standard BoardMetadata class and revert cache changes.

a0cb13a

shiv-tyagi requested changes Jan 19, 2026

View reviewed changes

garvit000 marked this pull request as draft January 31, 2026 17:32

shiv-tyagi and others added 24 commits February 12, 2026 03:35

builder: fix linting error

18f31d4

web: allow downloads for all terminal states

33e8711

web: add red color for TIMED_OUT state in UI

fd5913a

builder: add timeout handling using CBS_BUILD_TIMEOUT_SEC

1efff46

build_manager: track time_started and handle timeout state

d5bdcd5

docker-compose: add CBS_BUILD_TIMEOUT_SEC env var

c09a915

Fix rate limit exception handling in /generate endpoint

d632ff9

metadata_manager: add method to get feature defaults from firmware se…

cb84cb9

…rver

web: migrate web backend to fastapi

1a83d35

docker-compose: update default port number and CBS_REMOTES_RELOAD_TOK…

3d7637b

…EN for web service

README: fix commands to run the new web service

98e29e6

build_manager: fix linting issues

2e63195

builder: fix linting issues

e946217

.flake8: add flake8 config

69f7b31

.github: add workflow to run flake8

74470e3

Add missing TIMED_OUT literal to schema

ed51d6d

web: remove viewlog route, use root with build_id param instead

8587dd5

There is no advantage of an extra route to open the same page. The query parameter on main route should do.

build_manager: store version id in build metadata

92e8c75

web: add functionality to copy existing build configuration in add-bu…

9689878

…ild page

web:add donate button to index page

2babfbb

web: upgrade uvicorn to 0.40.0

fc5db88

web: correct paypal donation link

89f4d61

Web: Fix CAN category visibility and update backend board metadata

3d45a48

refactor board metadata and backend feature filtering

d029179

garvit000 mentioned this pull request Feb 12, 2026

Web: Fix CAN options visibility for non-CAN boards #227

Open

garvit000 closed this Feb 12, 2026

	self.attributes = attributes
	self.attributes = dict(attributes)

	list: A list of board metadata dictionaries, each containing
	the board name and whether it supports CAN (has_can).
	list: A list of Boards.

Conversation

garvit000 commented Jan 17, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

garvit000 commented Jan 18, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

garvit000 commented Feb 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments